DLC Queuing Produces Install Error

[acook]

When I clicked multiple DLCs to install, all will fail with errors either immediately or after the download completes. In addition the download bar will jump rapidly around.

There are two errors that pop up: "Failed to install" DLC and DLC "Corrupted"

Original DLC queuing PR: #395

[sharkwouter]

Thanks for reporting this. I tried to install DLC for AI War to see if I could reproduce this, but there I wasn't seeing this issue. Could you run Minigalaxy from the command line and see what the output is when you try this again? Also, which version of Minigalaxy is this?

[acook]

Version 1.2.5. I also saw the same issue with Battletech.

I'll see if I can replicate it with a non-Paradox game as well.

[NonMeme]

Just letting you know, I had an error installing a Stellaris DLC pack last year and a new one now where I cannot get the whole game to install. This one seems to be kind of finicky with MG.

Your error messages are completely different than mine, so I cannot quite help other than saying that.

[sharkwouter]

Thanks for updating @NonMeme, that's appreciated. What error message do you get?

[NonMeme]

Thanks for updating @NonMeme, that's appreciated. What error message do you get?

These. And I've tried to reinstall the game again off and on this month and last year too. It says on the Minigalaxy menu "in queue" and never goes to downloading.

[GB609]

About the jumping around of the progress bar: I've had the same. This happens when multiple large files are downloaded for a game, e.g. for some more recent windows games.
Cause:
Downloads for all files are started in parallel and download_manager reports progress for each file individually whenever a chunk is downloaded.
A percentage is calculated for the file which somehow tries to also consider that there are multiple files: file% * filenum / filecount. When there are 3 files, the first one thus is mapped 0-30, the second 30-60 etc. This value is simply passed through to gametile.set_progress. This sets the actual bar according to the last value received. This could work in theory, if the downloads were sequential. But they are not.

I see 2 ways to fix this:

1. Make downloads sequential
2. Let each download report progress in bytes and calculate the total percentage in gametile.set_progress which must keep track of current and total size per file.

[sharkwouter]

This could be related to the wine in the prefix not being used to install the dlc, but the system's wine instead. That is if you do not have Innoextract installed anyway.

[GB609]

I think the original error showed an .sh script, meanings its a linux game.
But i also get a lot of corrupted downloads in general. Could there be an issue with how downloaded chunks are consumed?

[sharkwouter]

Good point.

Yeah, the corrupted downloads are a separate issue. Sometimes resuming a download after restarting Minigalaxy corrupts it. I think I can fix that.

[GB609]

Small update about the download corruption that happened for me:
It appears i had a faulty combination of BIOS Firmware and RAM which also got me major issues when upgrading my system with pacman.
Since I upgraded the BIOS of my gaming rig, the download corruption has mostly disappeared.