Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Example Doesn't Have Correct Number of Variables #16

Open
emeeks opened this issue Sep 5, 2014 · 6 comments
Open

Comment Example Doesn't Have Correct Number of Variables #16

emeeks opened this issue Sep 5, 2014 · 6 comments

Comments

@emeeks
Copy link
Contributor

emeeks commented Sep 5, 2014

In the commented out example of how to use the code it only refers to topology (and not also the geometry) variable:

  • var features = cartogram(topology);
@timelyportfolio
Copy link

@emeeks Are you working on this? I have been working on an adaptation for rCharts. I discovered quickly that it is based on a very old version of topojson. I made some quick changes here to use version 1 of topojson, but this requires some slight changes to the code. I believe it could be easily fixed to drop in with no required changes.

@shawnbot
Copy link
Owner

shawnbot commented Sep 5, 2014

Hi guys, pull requests are much appreciated. I'm taking care of a newborn right now and don't have solid stretches of time to fix these issues. Thanks for looking out!

@shawnbot
Copy link
Owner

@timelyportfolio are you interested in submitting a pull request with your TopoJSON update?

@timelyportfolio
Copy link

honestly forgotten what I did, but will plan to dig up. Examples from that experiment.

http://timelyportfolio.github.io/rCharts_cartogram/world_usopen_mayer.html
http://timelyportfolio.github.io/rCharts_cartogram/world_usopen.html

@timelyportfolio
Copy link

@shawnbot I should be able to work on it this week

@timelyportfolio
Copy link

I have a working version with example using topojson 1.6.19. Let me know if you deem pull-requestable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants