Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug, can you fix that? #14

Open
freesunshine0316 opened this issue Aug 21, 2019 · 1 comment
Open

A bug, can you fix that? #14

freesunshine0316 opened this issue Aug 21, 2019 · 1 comment

Comments

@freesunshine0316
Copy link

coreference-resolution/src/coref.py

Line 211 in f368f5a

output, _ = self.lstm(packed)

I think there's a bug around the above code.
The LSTM encoding does not go along each sentence, as

pack_sequence

does not work as you thought.
@sushantakpani
Copy link

Author's note in span representation section (Lee 2017):
Independent LSTM for every sentence should be used as cross sentence context was not useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freesunshine0316 @sushantakpani