This repository was archived by the owner on May 26, 2023. It is now read-only.

Bnke0x0

low

require() should be used instead of assert()

Summary

Vulnerability Detail

Impact

require() should be used instead of assert()

Code Snippet

https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/universal/CrossDomainMessenger.sol#L294-L295

               'assert(msg.value == _value);'
                'assert(!failedMessages[versionedHash]);'

https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/universal/ProxyAdmin.sol#L227

                      'assert(false);'

Tool used

Manual Review

Recommendation

require() should be used instead of assert()