Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlad - Owner can't remove stakers which doesn't withdraw funds #244

Open
sherlock-admin2 opened this issue Sep 23, 2024 · 0 comments
Open

Comments

@sherlock-admin2
Copy link
Contributor

sherlock-admin2 commented Sep 23, 2024

vlad

Medium

Owner can't remove stakers which doesn't withdraw funds

Summary

If the staker decide not to withdraw funds, but became unavailable (key lose for example), then the staker will continue to hold the limited staker place. If many stakers became unavailable during the protocol time all 255 slots may be occupied by dead stakers and so rollup will stop working.

Root Cause

There are at most 255 stakers, if any stop withdrawing funds it is no longer possible to replace staker with another one.

Internal pre-conditions

Staker is not withdrawing funds.

External pre-conditions

No response

Attack Path

No response

Impact

  • Protocol insolvency in case stakers are not available.
  • Stakers can stop processing network to to stop the protocol and blackmail users with a lot of funds in the protocol.

PoC

No response

Mitigation

  • Remove check for withdrawAmount on staker removal.
@sherlock-admin3 sherlock-admin3 changed the title Bouncy Ruby Manatee - Owner can't remove stakers which doesn't withdraw funds vlad - Owner can't remove stakers which doesn't withdraw funds Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant