Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix console font to be monospaced also for box drawing chars #166

Open
m-schmoock opened this issue Dec 14, 2020 · 4 comments
Open

fix console font to be monospaced also for box drawing chars #166

m-schmoock opened this issue Dec 14, 2020 · 4 comments

Comments

@m-schmoock
Copy link
Contributor

m-schmoock commented Dec 14, 2020

The c-lightning summary plugin ( https://github.com/lightningd/plugins/tree/master/summary ) prints box drawing unicode characters. Turns out the current UI font is not able to monospace them correctly. See attached screenshot, the bars should be aligned in the middle.

https://en.wikipedia.org/wiki/Box_Drawing_(Unicode_block)

image

@shesek
Copy link
Owner

shesek commented Dec 16, 2020

Sounds acceptable to me. Have you tried running it with a monospace font? does it looks good?

@m-schmoock
Copy link
Contributor Author

@shesek
I tested it only on my nodes CLI and yes there it looks good.
From the screenshot above you can see that the app already uses a fixed font for that activity, BUT the box drawing chars are not fixed for this font. Which some fixed fonts have, as the box chars are UTF8 stuff.

@shesek
Copy link
Owner

shesek commented Jan 19, 2021

@m-schmoock Any idea which font would be suitable here?

@m-schmoock
Copy link
Contributor Author

A small research gave me this: https://stackoverflow.com/a/52712484/884474
Try using Lucida Sans Typewriter. If that doesn't work, try to ship it with
https://madmalik.github.io/mononoki or https://github.com/adobe-fonts/source-code-pro . Not sure if embedding a special font in the app is an option. So lets hope Lucida Sans Typewriter does the job ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants