You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are various places (example: matrix_getx, matrix_gety, sdl_event_break in out_sdl2.c) where an int is used instead of a uint.
Should we make variables strictly unsigned where it makes sense, or is allowed by all uses of that variable?
Of course, I'm only suggesting this because CLion told me to. :D
The text was updated successfully, but these errors were encountered:
Yeah, it should be unsigned for the most part.
The issue with that is that math is a bit iffy, you're bound to underflow when calculating things.
So some things still rely on signed positions.
But other than that, the default should be unsigned.
There are various places (example: matrix_getx, matrix_gety, sdl_event_break in out_sdl2.c) where an int is used instead of a uint.
Should we make variables strictly unsigned where it makes sense, or is allowed by all uses of that variable?
Of course, I'm only suggesting this because CLion told me to. :D
The text was updated successfully, but these errors were encountered: