You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for providing a great set of rules! We've encountered an unexpected behavior, and I'd like to discuss whether this is intentional or if there's something we can do about it.
The issue relates to traits. When we use a trait from a third-party package (a "vendor" package) without actually using any of its methods, no error is raised—regardless of method visibility. However, when we use our own traits within the project, unused methods are correctly reported. I would expect the same behavior for vendor traits as our project traits.
It looks like you are looking for detection of "unused trait use". Currently, there is no such thing, we only detect dead methods and dead constants so far. Thus, we do not report unused things in vendor as you cannot really remove the method from there.
But thanks for the idea, we can consider implementing this in future.
Hello,
Thank you for providing a great set of rules! We've encountered an unexpected behavior, and I'd like to discuss whether this is intentional or if there's something we can do about it.
The issue relates to traits. When we use a trait from a third-party package (a "vendor" package) without actually using any of its methods, no error is raised—regardless of method visibility. However, when we use our own traits within the project, unused methods are correctly reported. I would expect the same behavior for vendor traits as our project traits.
To illustrate this, I've prepared a minimal demo: https://github.com/klapuch/DeadCodeTest
Thank you!
The text was updated successfully, but these errors were encountered: