Refactor and fix linter

Author: shiranr

Diff for: .golangci.yml

@@ -11,3 +11,5 @@ ENABLE_LINTERS: # If you use ENABLE_LINTERS variable, all other linters will be
 SHOW_ELAPSED_TIME: true
 FILEIO_REPORTER: false
 # DISABLE_ERRORS: true # Uncomment if you want MegaLinter to detect errors but not block CI to pass
+ADDITIONAL_EXCLUDED_DIRECTORIES:
+  - "vendor"

Diff for: .mega-linter.yml

@@ -13,7 +13,8 @@ var (
 type emailHandler struct {
 }
 
-func GetEmailHandlerInstance() *emailHandler {
+// GetEmailHandlerInstance Get email handler instance
+func GetEmailHandlerInstance() LinkHandlerInterface {
 	if mailHandler == nil {
 		mailHandler = &emailHandler{}
 	}

Diff for: models/email_handler.go

@@ -5,33 +5,29 @@ import (
 	"net/url"
 	"os"
 	"path"
+	"path/filepath"
 	"regexp"
 	"strings"
 )
 
 var (
-	linkFileHandler *fileLinkHandler
+	internalLink *internalLinkHandler
 )
 
-type fileLinkHandler struct {
-	folderPath string
-	fileName   string
+type internalLinkHandler struct {
+	filePath string
 }
 
-func GetFileLinkHandler(filePath string) *fileLinkHandler {
-	fileData, err := NewFileData(filePath)
-	if err != nil {
-		return nil
-	}
-	linkFileHandler = &fileLinkHandler{
-		folderPath: fileData.folderPath,
-		fileName:   fileData.fileName,
+func GetInternalLinkHandler(filePath string) LinkHandlerInterface {
+	internalLink = &internalLinkHandler{
+		filePath: filePath,
 	}
-	return linkFileHandler
+	return internalLink
 }
 
-func (handler *fileLinkHandler) Handle(linkPath string) int {
-	linkedFileEscapedFullPath := handler.escapedFullPath(linkPath)
+func (handler *internalLinkHandler) Handle(linkPath string) int {
+	folderPath, fileName := filepath.Split(handler.filePath)
+	linkedFileEscapedFullPath := handler.escapedFullPath(folderPath, fileName, linkPath)
 	if strings.Contains(linkedFileEscapedFullPath, "?") {
 		linkedFileEscapedFullPath = strings.Split(linkedFileEscapedFullPath, "?")[0]
 	}
@@ -53,21 +49,20 @@ func (handler *fileLinkHandler) Handle(linkPath string) int {
 	return 200
 }
 
-func (handler *fileLinkHandler) escapedFullPath(extension string) string {
-	folderPath := handler.folderPath
-	if strings.HasPrefix(extension, "#") {
-		folderPath = path.Join(handler.folderPath, handler.fileName)
-	} else if strings.Contains(extension, "#") {
-		fileName := strings.Split(extension, "#")[0]
-		folderPath = path.Join(handler.folderPath, fileName)
+func (handler *internalLinkHandler) escapedFullPath(folderPath, fileName, linkPath string) string {
+	if strings.HasPrefix(linkPath, "#") {
+		folderPath = path.Join(folderPath, fileName)
+	} else if strings.Contains(linkPath, "#") {
+		fileName := strings.Split(linkPath, "#")[0]
+		folderPath = path.Join(folderPath, fileName)
 	} else {
-		folderPath = path.Join(handler.folderPath, extension)
+		folderPath = path.Join(folderPath, linkPath)
 	}
 	folderPath, _ = url.PathUnescape(folderPath)
 	return folderPath
 }
 
-func (handler *fileLinkHandler) fileContainsLink(titleLink string, fileText string) bool {
+func (handler *internalLinkHandler) fileContainsLink(titleLink string, fileText string) bool {
 	titleLink = strings.Split(titleLink, "#")[1]
 	title := strings.ReplaceAll(titleLink, "#", "")
 	title = strings.ReplaceAll(title, "(", "\\(")

Diff for: models/file_data.go

@@ -0,0 +1,45 @@
+package models
+
+import (
+	log "github.com/sirupsen/logrus"
+	"os"
+)
+
+type FileProcessor interface {
+	ProcessFile()
+}
+
+type fileProcessor struct {
+	resultChan    chan *LinkResult
+	filePath      string
+	fileLinesData map[int]string
+}
+
+func GetNewFileProcessor(filePath string, resultChan chan *LinkResult) FileProcessor {
+	return &fileProcessor{
+		filePath:   filePath,
+		resultChan: resultChan,
+	}
+}
+
+func (fp *fileProcessor) ProcessFile() {
+	defer wg.Done()
+	linkHandler := GetLinkProcessorInstance()
+	fileBytes, err := os.ReadFile(fp.filePath)
+	if err != nil {
+		log.WithFields(log.Fields{"error": err}).Error("failed to read file " + fp.filePath)
+		linkData := &LinkResult{
+			lineNumber: 0,
+			status:     404,
+			filePath:   fp.filePath,
+			linkType:   InternalLink,
+		}
+		fp.resultChan <- linkData
+		return
+	}
+	fileData := string(fileBytes)
+	linksPaths := linkHandler.ExtractLinks(fileData)
+	for _, linkData := range linksPaths {
+		fp.resultChan <- linkHandler.CheckLink(fp.filePath, linkData.Link, linkData.LinkLineNumber)
+	}
+}

Diff for: models/file_handler.go

@@ -30,27 +30,27 @@ func GetFilesProcessorInstance() FilesProcessor {
 
 func (fh *filesProcessor) Process(files []string) error {
 	for _, filePath := range files {
-		fileLinkData := FileLink{
+		fileLinkData := FileResultData{
 			FilePath: filePath,
-			Links:    []*Link{},
+			Links:    []*LinkResult{},
 			Error:    false,
 		}
 		fh.AddNewFile(&fileLinkData)
-		fileHandler := GetNewFileHandler(filePath, fh.Channel)
-		if fileHandler != nil {
+		fileProcessor := GetNewFileProcessor(filePath, fh.Channel)
+		if fileProcessor != nil {
 			wg.Add(1)
-			fh.invoke(fileHandler)
+			fh.invoke(fileProcessor)
 		}
 	}
 	wg.Wait()
 	fh.Close()
 	return fh.Print()
 }
 
-func (fh *filesProcessor) invoke(fileHandler FileHandler) {
+func (fh *filesProcessor) invoke(fileProcessor FileProcessor) {
 	if fh.serial {
-		fileHandler.HandleFile()
+		fileProcessor.ProcessFile()
 	} else {
-		go fileHandler.HandleFile()
+		go fileProcessor.ProcessFile()
 	}
 }

Diff for: models/file_link_handler.go

@@ -0,0 +1,5 @@
+package models
+
+type LinkHandlerInterface interface {
+	Handle(linkPath string) int
+}