|
| 1 | +From a0954304442fadf4555f596de4834bf671f0041b Mon Sep 17 00:00:00 2001 |
| 2 | +From: Shivam Mathur <shivam_jpr@hotmail.com> |
| 3 | +Date: Mon, 3 Mar 2025 09:31:20 +0000 |
| 4 | +Subject: [PATCH] Revert "Use pkg-config for ext/ldap without a directory |
| 5 | + (#17441)" |
| 6 | + |
| 7 | +This reverts commit 367787134761f8c0e90ea2b1dd402b6c5795c687. |
| 8 | +--- |
| 9 | + ext/ldap/config.m4 | 82 +++++++++++++++++++++------------------------- |
| 10 | + 1 file changed, 37 insertions(+), 45 deletions(-) |
| 11 | + |
| 12 | +diff --git a/ext/ldap/config.m4 b/ext/ldap/config.m4 |
| 13 | +index 09be81f6da..bb57d636dd 100644 |
| 14 | +--- a/ext/ldap/config.m4 |
| 15 | ++++ b/ext/ldap/config.m4 |
| 16 | +@@ -38,7 +38,6 @@ AC_DEFUN([PHP_LDAP_CHECKS], [ |
| 17 | + LDAP_LIBDIR=$1 |
| 18 | + fi |
| 19 | + fi |
| 20 | +- PHP_LDAP_PKGCONFIG=false |
| 21 | + ]) |
| 22 | + |
| 23 | + PHP_ARG_WITH([ldap], |
| 24 | +@@ -60,53 +59,52 @@ if test "$PHP_LDAP" != "no"; then |
| 25 | + [-DZEND_ENABLE_STATIC_TSRMLS_CACHE=1]) |
| 26 | + |
| 27 | + AS_VAR_IF([PHP_LDAP], [yes], [ |
| 28 | +- PKG_CHECK_MODULES([LDAP], [lber ldap]) |
| 29 | +- PHP_LDAP_PKGCONFIG=true |
| 30 | ++ for i in /usr/local /usr; do |
| 31 | ++ PHP_LDAP_CHECKS([$i]) |
| 32 | ++ done |
| 33 | + ], [PHP_LDAP_CHECKS([$PHP_LDAP])]) |
| 34 | + |
| 35 | +- AS_IF([test "$PHP_LDAP_PKGCONFIG" = true], [ |
| 36 | +- PHP_EVAL_INCLINE([$LDAP_CFLAGS]) |
| 37 | +- PHP_EVAL_LIBLINE([$LDAP_LIBS], [LDAP_SHARED_LIBADD]) |
| 38 | +- ], [ |
| 39 | +- AS_VAR_IF([LDAP_DIR],, [AC_MSG_ERROR([Cannot find ldap.h])]) |
| 40 | ++ AS_VAR_IF([LDAP_DIR],, [AC_MSG_ERROR([Cannot find ldap.h])]) |
| 41 | + |
| 42 | +- dnl -pc removal is a hack for clang |
| 43 | +- MACHINE_INCLUDES=$($CC -dumpmachine | $SED 's/-pc//') |
| 44 | ++ dnl -pc removal is a hack for clang |
| 45 | ++ MACHINE_INCLUDES=$($CC -dumpmachine | $SED 's/-pc//') |
| 46 | + |
| 47 | +- AH_TEMPLATE([HAVE_ORALDAP], |
| 48 | +- [Define to 1 if the ldap extension uses the Oracle Instant Client.]) |
| 49 | ++ AH_TEMPLATE([HAVE_ORALDAP], |
| 50 | ++ [Define to 1 if the ldap extension uses the Oracle Instant Client.]) |
| 51 | + |
| 52 | +- if test -f $LDAP_LIBDIR/liblber.a || test -f $LDAP_LIBDIR/liblber.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/liblber.a || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/liblber.$SHLIB_SUFFIX_NAME; then |
| 53 | +- PHP_ADD_LIBRARY_WITH_PATH([lber], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 54 | +- PHP_ADD_LIBRARY_WITH_PATH([ldap], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 55 | ++ if test -f $LDAP_LIBDIR/liblber.a || test -f $LDAP_LIBDIR/liblber.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/liblber.a || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/liblber.$SHLIB_SUFFIX_NAME; then |
| 56 | ++ PHP_ADD_LIBRARY_WITH_PATH([lber], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 57 | ++ PHP_ADD_LIBRARY_WITH_PATH([ldap], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 58 | + |
| 59 | +- elif test -f $LDAP_LIBDIR/libldap.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/libldap.$SHLIB_SUFFIX_NAME.3 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libldap.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libldap.$SHLIB_SUFFIX_NAME.3 || test -f $LDAP_LIBDIR/libldap.3.dylib; then |
| 60 | +- PHP_ADD_LIBRARY_WITH_PATH([ldap], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 61 | ++ elif test -f $LDAP_LIBDIR/libldap.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/libldap.$SHLIB_SUFFIX_NAME.3 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libldap.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libldap.$SHLIB_SUFFIX_NAME.3 || test -f $LDAP_LIBDIR/libldap.3.dylib; then |
| 62 | ++ PHP_ADD_LIBRARY_WITH_PATH([ldap], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 63 | + |
| 64 | +- elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME.12.1 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME.12.1; then |
| 65 | +- PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 66 | +- AC_DEFINE([HAVE_ORALDAP], [1]) |
| 67 | ++ elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME.12.1 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME.12.1; then |
| 68 | ++ PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 69 | ++ AC_DEFINE([HAVE_ORALDAP], [1]) |
| 70 | + |
| 71 | +- elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME.11.1 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME.11.1; then |
| 72 | +- PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 73 | +- AC_DEFINE([HAVE_ORALDAP], [1]) |
| 74 | ++ elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME.11.1 || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME.11.1; then |
| 75 | ++ PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 76 | ++ AC_DEFINE([HAVE_ORALDAP], [1]) |
| 77 | + |
| 78 | +- elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME; then |
| 79 | +- PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 80 | +- AC_DEFINE([HAVE_ORALDAP], [1]) |
| 81 | ++ elif test -f $LDAP_LIBDIR/libclntsh.$SHLIB_SUFFIX_NAME || test -f $LDAP_LIBDIR/$MACHINE_INCLUDES/libclntsh.$SHLIB_SUFFIX_NAME; then |
| 82 | ++ PHP_ADD_LIBRARY_WITH_PATH([clntsh], [$LDAP_LIBDIR], [LDAP_SHARED_LIBADD]) |
| 83 | ++ AC_DEFINE([HAVE_ORALDAP], [1]) |
| 84 | + |
| 85 | +- else |
| 86 | +- AC_MSG_ERROR([Cannot find ldap libraries in $LDAP_LIBDIR.]) |
| 87 | +- fi |
| 88 | ++ else |
| 89 | ++ AC_MSG_ERROR([Cannot find ldap libraries in $LDAP_LIBDIR.]) |
| 90 | ++ fi |
| 91 | + |
| 92 | +- PHP_ADD_INCLUDE([$LDAP_INCDIR]) |
| 93 | ++ PHP_ADD_INCLUDE([$LDAP_INCDIR]) |
| 94 | ++ PHP_SUBST([LDAP_SHARED_LIBADD]) |
| 95 | ++ AC_DEFINE([HAVE_LDAP], [1], |
| 96 | ++ [Define to 1 if the PHP extension 'ldap' is available.]) |
| 97 | + |
| 98 | +- dnl Save original values |
| 99 | +- _SAVE_CPPFLAGS=$CPPFLAGS |
| 100 | +- _SAVE_LIBS=$LIBS |
| 101 | +- CPPFLAGS="$CPPFLAGS -I$LDAP_INCDIR" |
| 102 | +- LIBS="$LIBS $LDAP_SHARED_LIBADD" |
| 103 | +- ]) |
| 104 | ++ dnl Save original values |
| 105 | ++ _SAVE_CPPFLAGS=$CPPFLAGS |
| 106 | ++ _SAVE_LIBS=$LIBS |
| 107 | ++ CPPFLAGS="$CPPFLAGS -I$LDAP_INCDIR" |
| 108 | ++ LIBS="$LIBS $LDAP_SHARED_LIBADD" |
| 109 | + |
| 110 | + dnl Check for 3 arg ldap_set_rebind_proc |
| 111 | + AC_CACHE_CHECK([for 3 arg ldap_set_rebind_proc], |
| 112 | +@@ -134,12 +132,6 @@ if test "$PHP_LDAP" != "no"; then |
| 113 | + ldap_whoami_s |
| 114 | + ])) |
| 115 | + |
| 116 | +- AS_IF([test "$PHP_LDAP_PKGCONFIG" = false], [ |
| 117 | +- dnl Restore original values |
| 118 | +- CPPFLAGS=$_SAVE_CPPFLAGS |
| 119 | +- LIBS=$_SAVE_LIBS |
| 120 | +- ]) |
| 121 | +- |
| 122 | + dnl SASL check |
| 123 | + AS_VAR_IF([PHP_LDAP_SASL], [no],, [ |
| 124 | + PKG_CHECK_MODULES([SASL], [libsasl2]) |
| 125 | +@@ -154,7 +146,7 @@ if test "$PHP_LDAP" != "no"; then |
| 126 | + [AC_CHECK_FUNC([ldap_simple_bind_s],, |
| 127 | + [AC_MSG_ERROR([LDAP library build check failed.])])]) |
| 128 | + |
| 129 | +- PHP_SUBST([LDAP_SHARED_LIBADD]) |
| 130 | +- AC_DEFINE([HAVE_LDAP], [1], |
| 131 | +- [Define to 1 if the PHP extension 'ldap' is available.]) |
| 132 | ++ dnl Restore original values |
| 133 | ++ CPPFLAGS=$_SAVE_CPPFLAGS |
| 134 | ++ LIBS=$_SAVE_LIBS |
| 135 | + fi |
| 136 | +-- |
| 137 | +2.47.1 |
| 138 | + |
0 commit comments