Skip to content

Commit e0852f6

Browse files
committed
feat: support additional disks
closes: #15 Signed-off-by: Fritz Schaal <[email protected]>
1 parent e33e2e3 commit e0852f6

File tree

10 files changed

+728
-100
lines changed

10 files changed

+728
-100
lines changed

README.md

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ libvirt:
3535

3636
## Running the provider
3737

38+
> **_NOTE:_**
39+
> `omni-infra-provider-libvirt` will not create storage pools nor networks.
40+
> It will optimistically assume that they already exist and are functional.
41+
3842
### Using Docker
3943

4044
Copy the provider credentials created in omni to an `.env` file
@@ -51,8 +55,7 @@ Example for using the above `ssh` based connection method:
5155
```shell
5256
docker run \
5357
--name omni-infra-provider-libvirt \
54-
--rm \
55-
-it \
58+
--rm -it \
5659
-e USER=$USER \
5760
--env-file /tmp/omni-provider-libvirt.env \
5861
-v /tmp/omni-provider-libvirt.yaml:/config.yaml \
@@ -70,8 +73,7 @@ Example for using the above `socket` based connection method:
7073
```shell
7174
docker run \
7275
--name omni-infra-provider-libvirt \
73-
--rm \
74-
-it \
76+
--rm -it \
7577
-e USER=$USER \
7678
--env-file /tmp/omni-provider-libvirt.env \
7779
-v /tmp/omni-provider-libvirt.yaml:/config.yaml \
@@ -80,7 +82,7 @@ docker run \
8082
--config-file /config.yaml
8183
```
8284

83-
## How to use in an Omni cluster templates
85+
## How to use in an Omni cluster template
8486

8587
See [test/](./test/) for some examples
8688

@@ -100,3 +102,9 @@ Build the binary:
100102
# e.g. for darwin
101103
make omni-infra-provider-libvirt-darwin-arm64
102104
```
105+
106+
Run the linter:
107+
108+
```shell
109+
make lint-fmt fmt
110+
```

api/specs/specs.pb.go

Lines changed: 87 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/specs/specs.proto

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,18 @@ package emuspecs;
33

44
option go_package = "github.com/siderolabs/omni-infra-provider-libvirt/api/specs";
55

6+
message AdditionalDisk {
7+
string type = 1;
8+
string volName = 3;
9+
}
10+
611
// MachineSpec is stored in Omni in the infra provisioner state.
712
message MachineSpec {
813
string uuid = 1; // required?
914
string schematic_id = 2;
1015
string talos_version = 3;
1116
string vm_vol_name = 10;
17+
repeated AdditionalDisk additional_disks = 11;
1218
string pool_name = 20;
1319
string vm_name = 21;
1420
}

0 commit comments

Comments
 (0)