Commit 176f9d9
feat: compute schematic id only from the extensions
When determining the schematic ID of a machine, instead of relying the ID on the schematic ID meta-extension, compute the ID by gathering the extensions on the machine. This way, the extension ID will not contain the META values, labels or the kernel args.
This ID is actually the ID we need, as when we compare the desired schematic with the actual one during a Talos upgrade, we are only interested in the changes in the list of extensions.
This does not cause the kernel args, labels, etc. to disappear, as they are used at installation time and preserved afterward (e.g., during upgrades).
Additionally:
- Remove the list of extensions from the `Schematic` resource, as it relied upon the schematics always being created through Omni. This is not always the case - i.e., when a partial join config is used. Therefore, instead of relying on it, we store the list of extensions by directly reading them from the machine and storing them on the `MachineStatus` resource.
- Skip setting the schematic META section at all if there are no labels set on Download Installation Media screen.
Closes #55.
Signed-off-by: Utku Ozdemir <[email protected]>1 parent 1e4e303 commit 176f9d9
File tree
31 files changed
+506
-261
lines changed- client
- api/omni/specs
- pkg
- constants
- omni/resources/omni
- cmd
- integration-test/pkg/tests
- omni
- frontend/src
- api
- omni/specs
- views/omni/Modals
- hack/test
- internal/backend
- grpc
- imagefactory
- runtime/omni
- controllers/omni
- internal
- talos
- task/machine
31 files changed
+506
-261
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| 130 | + | |
| 131 | + | |
130 | 132 | | |
131 | 133 | | |
132 | 134 | | |
133 | 135 | | |
134 | 136 | | |
135 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
136 | 141 | | |
137 | 142 | | |
138 | 143 | | |
| |||
907 | 912 | | |
908 | 913 | | |
909 | 914 | | |
910 | | - | |
| 915 | + | |
911 | 916 | | |
912 | 917 | | |
913 | 918 | | |
| |||
937 | 942 | | |
938 | 943 | | |
939 | 944 | | |
940 | | - | |
| 945 | + | |
0 commit comments