fix: filter out device mapper/lvm disks from block devices

Detect and filter out the device mapper devices (`dm-0`, `dm-1` etc.), commonly used for `lvm`, from the machine's block devices.
This will make them not appear in the list of disks on machines screen/`MachineStatus` resource. They will also not be listed in the install disk dropdown.

Signed-off-by: Utku Ozdemir <[email protected]>

Author: utkuozdemir

internal/backend/runtime/omni/controllers/omni/internal/task/machine/poll.go

@@ -353,6 +353,10 @@ func pollDisks(ctx context.Context, c *client.Client, info *Info) error {
 				return nil
 			}
 
+			if len(spec.SecondaryDisks) > 0 || spec.BusPath == "/virtual" { // not a real disk, e.g., a device mapper device (lvm)
+				return nil
+			}
+
 			info.Blockdevices = append(info.Blockdevices, &specs.MachineStatusSpec_HardwareStatus_BlockDevice{
 				Size:       spec.Size,
 				Model:      spec.Model,

internal/backend/runtime/omni/controllers/omni/machine_config_gen_options.go

@@ -92,7 +92,7 @@ func GenInstallConfig(machineStatus *omni.MachineStatus, clusterMachineTalosVers
 		candidates := machineStatus.TypedSpec().Value.Hardware.Blockdevices
 
 		candidates = xslices.Filter(candidates, func(disk *specs.MachineStatusSpec_HardwareStatus_BlockDevice) bool {
-			return !disk.Readonly && disk.Type != storage.Disk_CD.String() && disk.Size > installDiskMinSize
+			return !disk.Readonly && disk.Type != storage.Disk_CD.String() && disk.Size > installDiskMinSize && disk.BusPath != "/virtual"
 		})
 
 		sortFunc := func(a, b *specs.MachineStatusSpec_HardwareStatus_BlockDevice) int {

internal/backend/runtime/omni/controllers/omni/machine_config_gen_options_test.go

@@ -68,7 +68,7 @@ func TestGenInstallConfig(t *testing.T) {
 			},
 		},
 		{
-			name: "matched not usb",
+			name: "matched not usb not virtual",
 			machineStatusSpec: &specs.MachineStatusSpec{
 				Hardware: &specs.MachineStatusSpec_HardwareStatus{
 					Blockdevices: []*specs.MachineStatusSpec_HardwareStatus_BlockDevice{
@@ -77,6 +77,11 @@ func TestGenInstallConfig(t *testing.T) {
 							Size:      8e9,
 							Transport: "usb",
 						},
+						{
+							LinuxName: "/dev/dm-0",
+							Size:      8e9,
+							BusPath:   "/virtual",
+						},
 						{
 							LinuxName: "/dev/sdb",
 							Size:      10e9,
@@ -90,6 +95,11 @@ func TestGenInstallConfig(t *testing.T) {
 							Size:      7e9,
 							Transport: "usb",
 						},
+						{
+							LinuxName: "/dev/dm-1",
+							Size:      7e9,
+							BusPath:   "/virtual",
+						},
 					},
 				},
 			},