fix: skip applying maintenance config to unsupported machines

If a machine does not support multidoc (<1.5.0) or running un agent mode, do not fail the maintenance apply controller - skip applying without failure instead.

Signed-off-by: Utku Ozdemir <[email protected]>
(cherry picked from commit 56fbf31)

Author: utkuozdemir

.conform.yaml

@@ -12,7 +12,7 @@ policies:
           gitHubOrganization: siderolabs
       spellcheck:
         locale: US
-      maximumOfOneCommit: true
+      maximumOfOneCommit: false
       header:
         length: 89
         imperative: true

internal/backend/runtime/omni/controllers/omni/maintenance_config_status.go

@@ -27,8 +27,11 @@ import (
 	"github.com/siderolabs/talos/pkg/machinery/config/encoder"
 	"github.com/siderolabs/talos/pkg/machinery/config/types/meta"
 	"github.com/siderolabs/talos/pkg/machinery/config/types/runtime"
+	"github.com/siderolabs/talos/pkg/machinery/imager/quirks"
 	configres "github.com/siderolabs/talos/pkg/machinery/resources/config"
 	"go.uber.org/zap"
+	"google.golang.org/grpc/codes"
+	grpcstatus "google.golang.org/grpc/status"
 
 	"github.com/siderolabs/omni/client/pkg/omni/resources"
 	"github.com/siderolabs/omni/client/pkg/omni/resources/omni"
@@ -168,6 +171,15 @@ func (helper *maintenanceConfigStatusControllerHelper) transform(ctx context.Con
 		return xerrors.NewTaggedf[qtransform.SkipReconcileTag]("machine is not in maintenance mode")
 	}
 
+	talosVersion := machineStatus.TypedSpec().Value.TalosVersion
+	if talosVersion == "" {
+		return xerrors.NewTaggedf[qtransform.SkipReconcileTag]("machine has no talos version yet")
+	}
+
+	if !quirks.New(talosVersion).SupportsMultidoc() {
+		return xerrors.NewTaggedf[qtransform.SkipReconcileTag]("talos version does not support multidoc, nothing to do")
+	}
+
 	maintenanceTalosClient, err := helper.maintenanceClientFactory(ctx, machineStatus.TypedSpec().Value.ManagementAddress)
 	if err != nil {
 		return fmt.Errorf("error creating maintenance client: %w", err)
@@ -214,6 +226,10 @@ func (helper *maintenanceConfigStatusControllerHelper) transform(ctx context.Con
 		Data: patchedBytes,
 		Mode: machine.ApplyConfigurationRequest_AUTO,
 	}); err != nil {
+		if grpcstatus.Code(err) == codes.Unimplemented {
+			return xerrors.NewTaggedf[qtransform.SkipReconcileTag]("machine does not support applying configuration: %w", err)
+		}
+
 		return fmt.Errorf("error applying maintenance config: %w", err)
 	}
 

internal/backend/runtime/omni/controllers/omni/maintenance_config_status_test.go

@@ -67,6 +67,7 @@ func (suite *MachineStatusSnapshotControllerSuite) TestMaintenanceConfigStatus()
 	machineStatus.TypedSpec().Value.Maintenance = true
 
 	machineStatus.TypedSpec().Value.ManagementAddress = "test-address"
+	machineStatus.TypedSpec().Value.TalosVersion = "1.5.0"
 
 	suite.Require().NoError(suite.state.Create(suite.ctx, machineStatus))