[bug] wwid attribute can be values that are not JSON compatible #1921
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
The wwid disk attribute can ingest with a value that JSON does not work with. As a result machine listings in the Omni user interface do not work and machine management is more challenging.
Expected Behavior
Since the wwid attribute originates outside of Omni and Talos, even if the value resulting in this situation are invalid, Omni and Talos should deal with the value in a way that the relevant machines can still be readily managed and the UI does not fail.
Steps To Reproduce
- Boot an ISO for Talos 1.11.5 on Hyper-V on Windows build 28000.1199 against Omni 1.3.2.
- View the machines list in Omni
What browsers are you seeing the problem on?
Microsoft Edge
Anything else?
Further details in #1910 if I have not conveyed them here.
With release builds of Windows, Hyper-V has the attribute but gives a read error on it. On this build, it the attribute has a value as indicated in the example. The problematic value seemed to be the one for the Virtual DVD-ROM drive for the ISO.
The problematic value seemed to be "wwid": "t10.MSFT s\005\ufffdCw\003TF\224\225}|\ufffdbJ}"
Fetching the problematic wwid value does not seem to be an error of Talos as SystemRescueCD shows the same value.
Issue #1525 could be related since that talks about the generated JSON protocol interface.
The workaround I found for my situation was to use the omnictl delete link command with the ID. This removed the MachineStatus resource the UI choked on.