refactor: abort if neither source nor binary pkg

Either return the entry or raise an error if the package is neither a
source nor a binary package (instead of returning nothing).

Signed-off-by: Tamino Larisch <[email protected]>

Author: tamilari

src/debsbom/generate/cdx.py

@@ -76,10 +76,11 @@ def cdx_package_repr(
         entry.description = package.description
         entry.properties.add(cdx_model.Property(name="section", value=package.section))
         logger.debug(f"Created binary component: {entry}")
-        return entry
     elif package.is_source():
         logger.debug(f"Created source component: {entry}")
-        return entry
+    else:
+        raise RuntimeError(f"The package {package} is neither a source nor a binary package")
+    return entry
 
 
 def make_distro_component(

src/debsbom/generate/spdx.py

@@ -145,7 +145,6 @@ def spdx_package_repr(package: Package, vendor: str = "debian") -> spdx_package.
             url = url._replace(netloc=url.netloc.lower())
             spdx_pkg.homepage = urlunparse(url)
         logger.debug(f"Created binary package: {spdx_pkg}")
-        return spdx_pkg
     elif package.is_source():
         spdx_pkg = spdx_package.Package(
             spdx_id=Reference.make_from_pkg(package).as_str(SBOMType.SPDX),
@@ -171,7 +170,9 @@ def spdx_package_repr(package: Package, vendor: str = "debian") -> spdx_package.
             primary_package_purpose=spdx_package.PackagePurpose.SOURCE,
         )
         logger.debug(f"Created source package: {spdx_pkg}")
-        return spdx_pkg
+    else:
+        raise RuntimeError(f"The package {package} is neither a source nor a binary package")
+    return spdx_pkg
 
 
 def spdx_bom(