Refactor/optional SBOM dependencies #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilari
force-pushed
the
refactor/optional-sbom-dependencies
branch
from
93a25ae to
1f491c5
Compare
Collaborator
|
Nit: 2cba7a1 is not really a fix. It worked as intended before and is just a style issue since we take the reexport instead of the direct one. So I would suggest to change it to |
Signed-off-by: Tamino Larisch <[email protected]>
Previously, both libraries were always required, even if a user only intended to use one format, which would lead to errors if the unused dependency was missing. Now, users only need to install the specific dependency for the SBOM format they wish to use. This also means that missing dependency errors are now more precise, occurring only when a user tries to execute a command for a format whose required library is not installed. This update may simplify packaging efforts for distributions like Debian, as `debsbom` can now be packaged with just `python3-cyclonedx-lib` even if a `spdx-tools` package is not yet available. Signed-off-by: Tamino Larisch <[email protected]>
Signed-off-by: Tamino Larisch <[email protected]>
tamilari
force-pushed
the
refactor/optional-sbom-dependencies
branch
from
1f491c5 to
b890fe4
Compare
Contributor
Author
With the new changes, it wouldn't work like this. But yes, I agree, before it was just a style issue. Changed it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, both libraries were always required, even if a user only intended to use one format, which would lead to errors if the unused dependency was missing. Now, users only need to install the specific dependency for the SBOM format they wish to use. This also means that missing dependency errors are now more precise, occurring only when a user tries to execute a command for a format whose required library is not installed.
This update may simplify packaging efforts for distributions like Debian, as
debsbomcan now be packaged with justpython3-cyclonedx-libeven if aspdx-toolspackage is not yet available.