Test/test cdx and spdx individually #135
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tamino Larisch <[email protected]>
Previously, both libraries were always required, even if a user only intended to use one format, which would lead to errors if the unused dependency was missing. Now, users only need to install the specific dependency for the SBOM format they wish to use. This also means that missing dependency errors are now more precise, occurring only when a user tries to execute a command for a format whose required library is not installed. This update may simplify packaging efforts for distributions like Debian, as `debsbom` can now be packaged with just `python3-cyclonedx-lib` even if a `spdx-tools` package is not yet available. Signed-off-by: Tamino Larisch <[email protected]>
Signed-off-by: Tamino Larisch <[email protected]>
Ensure each SBOM type generates without dependencies for the other format. This prevents accidental imports of uninstalled optional dependencies from common code paths, ensuring strict adherence to each type's specific requirements. Signed-off-by: Tamino Larisch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, it is really valuable to test cdx and spdx individually. But I don't really like the idea of uninstalling a specific package, neither only testing one individually (and the other one with both dependencies installed), nor reinstalling everything. Any opinions?
Depends on #134