Skip to content

Commit 48bf966

Browse files
chintankavathiaspike-rabbit
authored andcommitted
refactor(element-ng): use OnPush change detection in remaining components
following components now use `ChangeDetectionStrategy.OnPush`: - si-badge - si-login-single-sign-on - si-password-strength - si-status-counter
1 parent f50ade5 commit 48bf966

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

projects/element-ng/badge/si-badge.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component, input } from '@angular/core';
5+
import { ChangeDetectionStrategy, Component, input } from '@angular/core';
66
import { type StatusType } from '@siemens/element-ng/common';
77
import { SiIconComponent } from '@siemens/element-ng/icon';
88

@@ -27,6 +27,7 @@ export type BadgeType =
2727
}
2828
<span class="text-truncate"><ng-content /></span>
2929
`,
30+
changeDetection: ChangeDetectionStrategy.OnPush,
3031
host: {
3132
role: 'status',
3233
class: 'badge',

projects/element-ng/landing-page/login-single-sign-on/si-login-single-sign-on.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component, input, output } from '@angular/core';
5+
import { ChangeDetectionStrategy, Component, input, output } from '@angular/core';
66
import { SiTranslatePipe, t } from '@siemens/element-translate-ng/translate';
77

88
/**
@@ -23,7 +23,8 @@ import { SiTranslatePipe, t } from '@siemens/element-translate-ng/translate';
2323
@Component({
2424
selector: 'si-login-single-sign-on',
2525
imports: [SiTranslatePipe],
26-
templateUrl: './si-login-single-sign-on.component.html'
26+
templateUrl: './si-login-single-sign-on.component.html',
27+
changeDetection: ChangeDetectionStrategy.OnPush
2728
})
2829
export class SiLoginSingleSignOnComponent {
2930
/**

projects/element-ng/password-strength/si-password-strength.component.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
import {
66
AfterViewInit,
7+
ChangeDetectionStrategy,
78
Component,
89
contentChild,
910
contentChildren,
@@ -24,6 +25,7 @@ import { SiPasswordStrengthDirective } from './si-password-strength.directive';
2425
</si-password-toggle>
2526
`,
2627
styleUrl: './si-password-strength.component.scss',
28+
changeDetection: ChangeDetectionStrategy.OnPush,
2729
host: {
2830
'[class.bad]': 'bad()',
2931
'[class.weak]': 'weak()',

projects/element-ng/status-counter/si-status-counter.component.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,22 @@
33
* SPDX-License-Identifier: MIT
44
*/
55
import { NgClass } from '@angular/common';
6-
import { booleanAttribute, Component, computed, input, numberAttribute } from '@angular/core';
6+
import {
7+
booleanAttribute,
8+
ChangeDetectionStrategy,
9+
Component,
10+
computed,
11+
input,
12+
numberAttribute
13+
} from '@angular/core';
714
import { SiIconComponent } from '@siemens/element-ng/icon';
815

916
@Component({
1017
selector: 'si-status-counter, si-icon-status',
1118
imports: [NgClass, SiIconComponent],
1219
templateUrl: './si-status-counter.component.html',
13-
styleUrl: './si-status-counter.component.scss'
20+
styleUrl: './si-status-counter.component.scss',
21+
changeDetection: ChangeDetectionStrategy.OnPush
1422
})
1523
export class SiStatusCounterComponent {
1624
/** Icon to display. */

0 commit comments

Comments
 (0)