Skip to content

Commit 4e5b39b

Browse files
committed
chore(fomly): set OnPush as default for formly wrappers
1 parent 9b762a9 commit 4e5b39b

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

projects/element-ng/formly/wrapper/si-formly-fieldset.component.ts

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,27 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component } from '@angular/core';
5+
import {
6+
ChangeDetectionStrategy,
7+
ChangeDetectorRef,
8+
Component,
9+
inject,
10+
OnChanges
11+
} from '@angular/core';
612
import { FieldWrapper, FormlyModule } from '@ngx-formly/core';
713
import { SiFormFieldsetComponent } from '@siemens/element-ng/form';
814

915
@Component({
1016
selector: 'si-formly-fieldset',
1117
imports: [FormlyModule, SiFormFieldsetComponent],
12-
templateUrl: './si-formly-fieldset.component.html'
18+
templateUrl: './si-formly-fieldset.component.html',
19+
changeDetection: ChangeDetectionStrategy.OnPush
1320
})
14-
export class SiFormlyFieldsetComponent extends FieldWrapper {
21+
export class SiFormlyFieldsetComponent extends FieldWrapper implements OnChanges {
22+
private cdRef = inject(ChangeDetectorRef);
23+
ngOnChanges(): void {
24+
this.cdRef.markForCheck();
25+
}
1526
protected get label(): string | undefined {
1627
return this.props.label && this.props.hideLabel !== true ? this.props.label : undefined;
1728
}

projects/element-ng/formly/wrapper/si-formly-horizontal-wrapper.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component } from '@angular/core';
5+
import { ChangeDetectionStrategy, Component } from '@angular/core';
66
import { FieldWrapper, FormlyModule } from '@ngx-formly/core';
77

88
@Component({
99
selector: 'si-formly-horizontal-wrapper',
1010
imports: [FormlyModule],
11-
templateUrl: './si-formly-horizontal-wrapper.component.html'
11+
templateUrl: './si-formly-horizontal-wrapper.component.html',
12+
changeDetection: ChangeDetectionStrategy.OnPush
1213
})
1314
export class SiFormlyHorizontalWrapperComponent extends FieldWrapper {}

projects/element-ng/formly/wrapper/si-formly-icon-wrapper.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright (c) Siemens 2016 - 2025
33
* SPDX-License-Identifier: MIT
44
*/
5-
import { Component } from '@angular/core';
5+
import { ChangeDetectionStrategy, Component } from '@angular/core';
66
import { FieldWrapper } from '@ngx-formly/core';
77
import { SiTooltipDirective } from '@siemens/element-ng/tooltip';
88
import { SiTranslatePipe } from '@siemens/element-translate-ng/translate';
@@ -11,6 +11,7 @@ import { SiTranslatePipe } from '@siemens/element-translate-ng/translate';
1111
selector: 'si-formly-icon-wrapper',
1212
imports: [SiTooltipDirective, SiTranslatePipe],
1313
templateUrl: './si-formly-icon-wrapper.component.html',
14-
styleUrl: './si-formly-icon-wrapper.component.scss'
14+
styleUrl: './si-formly-icon-wrapper.component.scss',
15+
changeDetection: ChangeDetectionStrategy.OnPush
1516
})
1617
export class SiFormlyIconWrapperComponent extends FieldWrapper {}

0 commit comments

Comments
 (0)