Skip to content

Commit d7f46ae

Browse files
akashsonunespike-rabbit
authored andcommitted
refactor: improve type safety
1 parent d3b7316 commit d7f46ae

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

projects/charts-ng/src/components/si-chart-cartesian/si-chart-cartesian.component.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
import { Component, input, OnChanges, SimpleChanges } from '@angular/core';
66

77
import { echarts } from '../../shared/echarts.custom';
8-
import { LegendComponentOption, TooltipComponentOption } from '../../shared/echarts.model';
8+
import {
9+
GridComponentOption,
10+
LegendComponentOption,
11+
TooltipComponentOption
12+
} from '../../shared/echarts.model';
913
import { SiChartLoadingSpinnerComponent } from '../si-chart-loading-spinner/si-chart-loading-spinner.component';
1014
import { SiChartComponent } from '../si-chart/si-chart.component';
1115
import {
@@ -338,11 +342,11 @@ export class SiChartCartesianComponent extends SiChartComponent implements OnCha
338342
return !!seriesValue?.some(series => 'symbol' in series && series.symbol !== 'circle');
339343
}
340344

341-
private getGrid(): any {
345+
private getGrid(): GridComponentOption | GridComponentOption[] {
342346
const subChartGrids = this.subChartGrids();
343347
if (subChartGrids) {
344348
subChartGrids.forEach(g => (g.containLabel = false));
345-
return subChartGrids;
349+
return subChartGrids as GridComponentOption[];
346350
}
347351
return {};
348352
}

projects/charts-ng/src/components/si-chart-circle/si-chart-circle.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { PieSeriesOption } from '../../shared/echarts.model';
88
import { SiChartLoadingSpinnerComponent } from '../si-chart-loading-spinner/si-chart-loading-spinner.component';
99
import { SiChartComponent } from '../si-chart/si-chart.component';
1010
import { SiCustomLegendComponent } from '../si-custom-legend/si-custom-legend.component';
11-
import { CircleChartSeries, CircleValueUpdate } from './si-chart-circle.interface';
11+
import { CircleChartData, CircleChartSeries, CircleValueUpdate } from './si-chart-circle.interface';
1212

1313
@Component({
1414
selector: 'si-chart-circle',
@@ -63,7 +63,7 @@ export class SiChartCircleComponent extends SiChartComponent {
6363
changeSingleValue(index: number, valueIndex: number, value: number): void {
6464
const optionSeries = this.actualOptions.series as PieSeriesOption[];
6565
const series = optionSeries[index].data!;
66-
(series[valueIndex] as any).value = value;
66+
(series[valueIndex] as CircleChartData).value = value;
6767
this.updateEChart();
6868
}
6969

@@ -77,7 +77,7 @@ export class SiChartCircleComponent extends SiChartComponent {
7777
if (!currentSeries) {
7878
return;
7979
}
80-
(currentSeries[update.valueIndex] as any).value = update.value;
80+
(currentSeries[update.valueIndex] as CircleChartData).value = update.value;
8181
});
8282

8383
this.updateEChart();

0 commit comments

Comments
 (0)