Skip to content

Conversation

@dauriamarco
Copy link
Member

@dauriamarco dauriamarco commented Aug 19, 2025

Adds the button group with sub-variants: button-groups, split-button, toolbar, and also renames the segmented-button.
Here's some screenshots for a quick overview:

image image image

Related to #250


@dauriamarco dauriamarco self-assigned this Aug 19, 2025
@dauriamarco dauriamarco added the feature Marks feature requests and feature implementations label Aug 19, 2025
@dauriamarco
Copy link
Member Author

Hi @chintankavathia, whenever you have some time, would you be so kind as to help me generate the VRTs for this pull request as well? Thanks a lot in advance.

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

@chintankavathia
Copy link
Member

Hi @chintankavathia, whenever you have some time, would you be so kind as to help me generate the VRTs for this pull request as well? Thanks a lot in advance.

seems like some ally issue Ensure buttons have discernible text can you ensure icon only buttons are having aria-label

@dauriamarco dauriamarco force-pushed the feat/split-button branch 2 times, most recently from 4ac44d3 to 343bdbf Compare August 19, 2025 11:33
@dauriamarco dauriamarco marked this pull request as ready for review August 19, 2025 11:34
@dauriamarco dauriamarco requested a review from a team as a code owner August 19, 2025 11:34
Copy link
Member

@chintankavathia chintankavathia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dauriamarco focus ring doesn't seem to be placed correctly when compared to figma specs.
image

figma:

image

also the dropdown items focus ring is clipped from both sides

image

@dauriamarco
Copy link
Member Author

dauriamarco commented Aug 20, 2025

@chintankavathia I might be wrong, but to me it looks like the Figma example is slightly off. Otherwise, it would mean that the focus state of any other button is currently incorrect in the code. What do you say @hbxes?

For me it would look like this right now:
image
image

@kfenner kfenner added this to the 48.0.0 milestone Aug 20, 2025
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually need to wait here, until we have the new button radios, as this will affect the code here

@dauriamarco dauriamarco force-pushed the feat/split-button branch 3 times, most recently from ce55efa to 267d98a Compare August 21, 2025 18:18
@hbxes
Copy link
Member

hbxes commented Aug 26, 2025

@dauriamarco the figma file in terms of the focus is fixed

@kfenner kfenner removed this from the 48.0.0 milestone Aug 26, 2025
@dauriamarco dauriamarco marked this pull request as draft September 11, 2025 21:51
@dauriamarco
Copy link
Member Author

@dauriamarco Awesome, thank you! Three points: Can you add VRTs etc. and secondly, add some screenshots of the work to the main description of the PR above? This will help getting a quick overview of the work. Third, did you discuss the component name already with somebody in the team? I just want to note that iX has a toggle-button and we might want to align with iX here and quickly discuss the naming.

Thanks @kfenner 🙌 I’ll try adding the VRTs again, so far I’ve had issues running them locally and had to ask others to generate them for me, but I’ll give it another shot later on my machine to see if things are working now.

On the naming: I wasn’t fully decided between the two. I went with selection-buttons because it felt a bit more generic and aligned with the functionality of the button group itself, but I haven’t had a definitive discussion with anyone yet. Totally fine to revisit this and align with iX if needed.

@dauriamarco dauriamarco force-pushed the feat/split-button branch 2 times, most recently from a993129 to d03b1f7 Compare October 2, 2025 21:34
@dauriamarco dauriamarco marked this pull request as ready for review October 3, 2025 07:48
@dauriamarco dauriamarco force-pushed the feat/split-button branch 2 times, most recently from 382d6df to 903e82b Compare October 20, 2025 11:48
@github-actions
Copy link

Code Coverage

Copy link
Member

@kfenner kfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@kfenner kfenner dismissed stale reviews from spike-rabbit and chintankavathia October 31, 2025 15:42

addressed

@kfenner kfenner merged commit bd261ba into main Oct 31, 2025
11 checks passed
@kfenner kfenner deleted the feat/split-button branch October 31, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Marks feature requests and feature implementations released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants