Skip to content

Conversation

@spike-rabbit
Copy link
Member

Publish the documentation on main runs.

See for a working version: https://spike-rabbit.github.io/element/components/
Examples are broken because of absolute link, but they should be working with element.siemens.io.

Code is on the main branch.

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


Copy link
Member

@fh1ch fh1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spike-rabbit thanks a ton for the merge request 🙇

Just one nit from my end, otherwise perfectly fine 🏓

@spike-rabbit spike-rabbit force-pushed the build/deploy-examples branch from fa92d77 to 3c6c2e0 Compare May 16, 2025 08:29
@spike-rabbit spike-rabbit requested a review from fh1ch May 16, 2025 08:33
Copy link
Member

@fh1ch fh1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spike-rabbit thanks a ton for the rework, all good now 💯

LGTM 👍

@fh1ch fh1ch merged commit 5c1f7b1 into main May 16, 2025
6 checks passed
@fh1ch fh1ch deleted the build/deploy-examples branch May 16, 2025 08:35
@fh1ch fh1ch self-assigned this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants