refactor(tree-view): use better input names #704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEPRECATED: following inputs from `SiTreeViewComponent` are now deprecated with replacement. - `folderStateStart` (use `folderStateEnd`) - `isVirtualized` (use `disableVirtualization`) - `enableStateIndicator` (use `hideStateIndicator`) - `enableIcon` (use `hideIcon`) - `enableContextMenuButton` (use `hideContextMenuButton`) - `inheritChecked` (use `preventInheritChecked`) Note that replaced inputs have inverted behavior. eg, // Before `<si-tree-view [enableIcon]="false">` // After `<si-tree-view hideIcon>` or `<si-tree-view [hideIcon]="true">`
Member
|
@chintankavathia Thank you for this. However, I think we shouldn't do this as there is not too much value for the users and then we have lots of deprecations just because of the name (and default value). We should first think about the future of the tree and whether we might want to switch to a new implementation (using cdk, perhaps) for a declarative tree and then making a factory for that which is closer to the API of the current tree. And then finally deprecating the whole current tree alltogether. I just don't see a priority for this atm. as almost nobody complaints about the current tree and it is very stable and works in huge applications. |
Member
|
I'll close it for now. We can re-open if required when we decide on the future of the tree 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATED: following inputs from
SiTreeViewComponentare now deprecated with replacement.folderStateStart(usefolderStateEnd)isVirtualized(usedisableVirtualization)enableStateIndicator(usehideStateIndicator)enableIcon(usehideIcon)enableContextMenuButton(usehideContextMenuButton)inheritChecked(usepreventInheritChecked)Note that replaced inputs have inverted behavior. eg,
// Before
<si-tree-view [enableIcon]="false">// After
<si-tree-view hideIcon>or<si-tree-view [hideIcon]="true">