Docs/hyperlink #131
Docs/hyperlink #131
Conversation
Changed table to bullet list for consistency, clarify descriptions, and reference the official MDN documentation instead of W3Schools. Also removed the separate 'Disabled' option bullet.
Updated section headings for categorical, sequential, and comparative data to use proper heading levels. Improved clarity in sequential and comparative data descriptions. Added a link to the UX writing style guide for error messages.
Added an info block recommending the use of standard hyperlinks for inline links and provided a direct MDN reference
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Updated the reference to the UX writing style guide in the charts overview documentation to point to the correct path.
flxlst09
left a comment
flxlst09
left a comment
There was a problem hiding this comment.
Only a small wording suggestion, thanks.
Updated the info box in the link button guide to use 'inline hyperlinks' instead of 'actual hyperlinks' for clearer guidance.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the documentation by using proper headings for chart data types and adding information about hyperlinks. The changes are good, but I've found a few areas for improvement. In charts-overview/index.mdx, there's a minor style guide violation and a list formatting issue. In link-button/guide.md, I've suggested a larger change to address multiple issues at once, including removing non-standard <br/> tags, fixing typos and incorrect links, and restoring a removed option to maintain consistency within the document.
tokyojen
left a comment
tokyojen
left a comment
There was a problem hiding this comment.
Just a couple small things.
Co-authored-by: tokyojen <[email protected]>
💡 What is the current behavior?
Hyperlinks are not mentioned at all
GitHub Issue Number: #
🆕 What is the new behavior?
👨💻 Help & support