-
Notifications
You must be signed in to change notification settings - Fork 12
docs(IX-3684): update ix to v4 #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @alexkaduk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant version upgrade for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation and runtime examples to support version 4 of Siemens Industrial Experience (iX). The changes include updating the playground version, runtime paths, and dependencies in the example projects. The dependency updates, especially for AG Grid, align with the v4 migration guide. I've noted a potential issue with using latest for the @siemens/ix-echarts package in the example projects, as it could lead to version mismatches. Overall, the changes are consistent and well-aligned with the goal of upgrading to v4.
| "@siemens/ix-angular": "<VERSION>", | ||
| "@siemens/ix-aggrid": "<VERSION>", | ||
| "@siemens/ix-echarts": "<VERSION>", | ||
| "@siemens/ix-echarts": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using latest for @siemens/ix-echarts could introduce breaking changes if its version becomes incompatible with the other @siemens/ix-* packages, which are pinned to a specific version via the <VERSION> placeholder. To ensure compatibility and prevent unexpected issues in the StackBlitz examples, it would be safer to revert this to <VERSION>, assuming ix-echarts follows the same versioning scheme as the core ix library.
| "@siemens/ix-echarts": "latest", | |
| "@siemens/ix-echarts": "<VERSION>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same approach as for "@siemens/ix-icons": "latest", is used
| "@siemens/ix-angular": "<VERSION>", | ||
| "@siemens/ix-aggrid": "<VERSION>", | ||
| "@siemens/ix-echarts": "<VERSION>", | ||
| "@siemens/ix-echarts": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using latest for @siemens/ix-echarts could introduce breaking changes if its version becomes incompatible with the other @siemens/ix-* packages, which are pinned to a specific version via the <VERSION> placeholder. To ensure compatibility and prevent unexpected issues in the StackBlitz examples, it would be safer to revert this to <VERSION>, assuming ix-echarts follows the same versioning scheme as the core ix library.
| "@siemens/ix-echarts": "latest", | |
| "@siemens/ix-echarts": "<VERSION>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same approach as for "@siemens/ix-icons": "latest", is used
| "@siemens/ix": "<VERSION>", | ||
| "@siemens/ix-aggrid": "<VERSION>", | ||
| "@siemens/ix-echarts": "<VERSION>", | ||
| "@siemens/ix-echarts": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using latest for @siemens/ix-echarts could introduce breaking changes if its version becomes incompatible with the other @siemens/ix-* packages, which are pinned to a specific version via the <VERSION> placeholder. To ensure compatibility and prevent unexpected issues in the StackBlitz examples, it would be safer to revert this to <VERSION>, assuming ix-echarts follows the same versioning scheme as the core ix library.
| "@siemens/ix-echarts": "latest", | |
| "@siemens/ix-echarts": "<VERSION>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same approach as for "@siemens/ix-icons": "latest", is used
| "@siemens/ix-react": "<VERSION>", | ||
| "@siemens/ix-aggrid": "<VERSION>", | ||
| "@siemens/ix-echarts": "<VERSION>", | ||
| "@siemens/ix-echarts": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using latest for @siemens/ix-echarts could introduce breaking changes if its version becomes incompatible with the other @siemens/ix-* packages, which are pinned to a specific version via the <VERSION> placeholder. To ensure compatibility and prevent unexpected issues in the StackBlitz examples, it would be safer to revert this to <VERSION>, assuming ix-echarts follows the same versioning scheme as the core ix library.
| "@siemens/ix-echarts": "latest", | |
| "@siemens/ix-echarts": "<VERSION>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same approach as for "@siemens/ix-icons": "latest", is used
| "@siemens/ix-vue": "<VERSION>", | ||
| "@siemens/ix-aggrid": "<VERSION>", | ||
| "@siemens/ix-echarts": "<VERSION>", | ||
| "@siemens/ix-echarts": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using latest for @siemens/ix-echarts could introduce breaking changes if its version becomes incompatible with the other @siemens/ix-* packages, which are pinned to a specific version via the <VERSION> placeholder. To ensure compatibility and prevent unexpected issues in the StackBlitz examples, it would be safer to revert this to <VERSION>, assuming ix-echarts follows the same versioning scheme as the core ix library.
| "@siemens/ix-echarts": "latest", | |
| "@siemens/ix-echarts": "<VERSION>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same approach as for "@siemens/ix-icons": "latest", is used
No description provided.