-
Notifications
You must be signed in to change notification settings - Fork 13
feat(angular): update angular starter application to v4 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7318f3e
feat: angular starter app
Nadim901 8b3dc10
migrate buttons
danielleroux 267cd5c
migrate remaining components
danielleroux 04aa09f
migrate to ix grid theme v4
danielleroux eb89b5e
Removed css aggrid theme
danielleroux c2fecb8
Merge remote-tracking branch 'origin/main' into feat/angular-starter
danielleroux 78ae2e4
fix copy theme script
danielleroux 5a2f109
cleanup angular versions
danielleroux cdb7457
refactor theme copy
danielleroux 0cb6da7
apply router feedback
danielleroux 0db0c64
Adapt review comments
danielleroux e91a791
update nodejs
danielleroux 870e1a3
allow ts
danielleroux 34c7ea8
switch to js copy script
danielleroux 119ad8c
fix review comments
danielleroux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Editor configuration, see https://editorconfig.org | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 2 | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.ts] | ||
| quote_type = single | ||
| ij_typescript_use_double_quotes = false | ||
|
|
||
| [*.md] | ||
| max_line_length = off | ||
| trim_trailing_whitespace = false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # See https://docs.github.com/get-started/getting-started-with-git/ignoring-files for more about ignoring files. | ||
|
|
||
| # Compiled output | ||
| /dist | ||
| /tmp | ||
| /out-tsc | ||
| /bazel-out | ||
|
|
||
| # Node | ||
| /node_modules | ||
| npm-debug.log | ||
| yarn-error.log | ||
|
|
||
| # IDEs and editors | ||
| .idea/ | ||
| .project | ||
| .classpath | ||
| .c9/ | ||
| *.launch | ||
| .settings/ | ||
| *.sublime-workspace | ||
|
|
||
| # Visual Studio Code | ||
| .vscode/* | ||
| !.vscode/settings.json | ||
| !.vscode/tasks.json | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json | ||
| .history/* | ||
|
|
||
| # Miscellaneous | ||
| /.angular/cache | ||
| .sass-cache/ | ||
| /connect.lock | ||
| /coverage | ||
| /libpeerconnection.log | ||
| testem.log | ||
| /typings | ||
|
|
||
| # System files | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Playwright | ||
| node_modules/ | ||
| /test-results/ | ||
| /playwright-report/ | ||
| /blob-report/ | ||
| /playwright/.cache/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=827846 | ||
| "recommendations": ["angular.ng-template"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "ng serve", | ||
| "type": "chrome", | ||
| "request": "launch", | ||
| "preLaunchTask": "npm: start", | ||
| "url": "http://localhost:4200/" | ||
| }, | ||
| { | ||
| "name": "ng test", | ||
| "type": "chrome", | ||
| "request": "launch", | ||
| "preLaunchTask": "npm: test", | ||
| "url": "http://localhost:9876/debug.html" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?LinkId=733558 | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "type": "npm", | ||
| "script": "start", | ||
| "isBackground": true, | ||
| "problemMatcher": { | ||
| "owner": "typescript", | ||
| "pattern": "$tsc", | ||
| "background": { | ||
| "activeOnStart": true, | ||
| "beginsPattern": { | ||
| "regexp": "(.*?)" | ||
| }, | ||
| "endsPattern": { | ||
| "regexp": "bundle generation complete" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "npm", | ||
| "script": "test", | ||
| "isBackground": true, | ||
| "problemMatcher": { | ||
| "owner": "typescript", | ||
| "pattern": "$tsc", | ||
| "background": { | ||
| "activeOnStart": true, | ||
| "beginsPattern": { | ||
| "regexp": "(.*?)" | ||
| }, | ||
| "endsPattern": { | ||
| "regexp": "bundle generation complete" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # `@siemens/ix-angular` + Angular + Angular CLI | ||
|
|
||
| ## A starter template for Angular applications using Siemens Industrial Experience (ix-Angular). | ||
|
|
||
| ## Install dependencies | ||
|
|
||
| Execute pnpm install/npm install | ||
|
|
||
| ## Development | ||
|
|
||
| Execute `pnpm start` | ||
|
|
||
| ## Build | ||
|
|
||
| Execute `pnpm build` | ||
| The build artifacts will be stored in the dist/ directory | ||
|
|
||
| ## Testing | ||
|
|
||
| ### Unit Tests (Jasmine + Karma) | ||
|
|
||
| Execute `pnpm test` | ||
|
|
||
| ### E2E tests (playwright) | ||
|
|
||
| Execute `pnpm e2e` | ||
|
|
||
| ### Generate Components/Services | ||
|
|
||
| pnpm ng generate component [name] | ||
|
|
||
| pnpm ng generate service [name] | ||
|
|
||
| pnpm ng generate pipe [name] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| { | ||
| "$schema": "./node_modules/@angular/cli/lib/config/schema.json", | ||
| "version": 1, | ||
| "newProjectRoot": "projects", | ||
| "projects": { | ||
| "ixd-angular-starter": { | ||
| "projectType": "application", | ||
| "schematics": { | ||
| "@schematics/angular:component": { | ||
| "style": "scss" | ||
| } | ||
| }, | ||
| "root": "", | ||
| "sourceRoot": "src", | ||
| "prefix": "app", | ||
| "architect": { | ||
| "build": { | ||
| "builder": "@angular-devkit/build-angular:application", | ||
| "options": { | ||
| "outputPath": "dist", | ||
| "index": "src/index.html", | ||
| "browser": "src/main.ts", | ||
| "polyfills": ["zone.js"], | ||
| "tsConfig": "tsconfig.app.json", | ||
| "inlineStyleLanguage": "scss", | ||
| "assets": [ | ||
| { | ||
| "glob": "**/*", | ||
| "input": "public" | ||
| }, | ||
| "src/assets" | ||
| ], | ||
| "styles": ["src/styles.scss"], | ||
| "scripts": [] | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "budgets": [ | ||
| { | ||
| "type": "initial", | ||
| "maximumWarning": "5MB", | ||
| "maximumError": "5MB" | ||
| }, | ||
| { | ||
| "type": "anyComponentStyle", | ||
| "maximumWarning": "4kB", | ||
| "maximumError": "8kB" | ||
| } | ||
| ], | ||
| "outputHashing": "all" | ||
| }, | ||
| "development": { | ||
| "optimization": false, | ||
| "extractLicenses": false, | ||
| "sourceMap": true | ||
| } | ||
| }, | ||
| "defaultConfiguration": "production" | ||
| }, | ||
| "serve": { | ||
| "builder": "@angular-devkit/build-angular:dev-server", | ||
| "configurations": { | ||
| "production": { | ||
| "buildTarget": "ixd-angular-starter:build:production" | ||
| }, | ||
| "development": { | ||
| "buildTarget": "ixd-angular-starter:build:development" | ||
| } | ||
| }, | ||
| "defaultConfiguration": "development" | ||
| }, | ||
| "extract-i18n": { | ||
| "builder": "@angular-devkit/build-angular:extract-i18n" | ||
| }, | ||
| "test": { | ||
| "builder": "@angular-devkit/build-angular:karma", | ||
| "options": { | ||
| "polyfills": ["zone.js", "zone.js/testing"], | ||
| "tsConfig": "tsconfig.spec.json", | ||
| "karmaConfig": "karma.config.js", | ||
| "inlineStyleLanguage": "scss", | ||
| "assets": [ | ||
| { | ||
| "glob": "**/*", | ||
| "input": "public" | ||
| } | ||
| ], | ||
| "styles": ["src/styles.scss"], | ||
| "scripts": [] | ||
| } | ||
| }, | ||
| "lint": { | ||
| "builder": "@angular-eslint/builder:lint", | ||
| "options": { | ||
| "lintFilePatterns": ["src/**/*.ts", "src/**/*.html"] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "cli": { | ||
| "schematicCollections": [ | ||
| "angular-eslint" | ||
| ], | ||
| "analytics": false | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.