Skip to content

ModalConfig type contains 'keyboard' property instead of 'closeOnEscape' #2235

@lilahagyma

Description

@lilahagyma

Prerequisites

  • I have read the Contributing Guidelines.
  • I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?

Hi All,
I was trying to disable close on escape for a modal dialog in Angular and found that the ModalConfig expects a 'keyboard' property which doesn't do anything and it doesn't accept the correct 'closeOnEscape' property (unless I force it to).

What type of frontend framework are you seeing the problem on?

Angular (Standalone)

On which version of the frontend framework are you experiencing the issue?

@angular/[email protected]

Which version of iX do you use?

3.2.0

Code to produce this issue.

// Compiles, but doesn't work
this.modalService.open({
  content: MyModalComponent,
  keyboard: false,
});

// Does not compile
this.modalService.open({
  content: MyModalComponent,
  closeOnEscape: false,
});

// Compiles and works
this.modalService.open({
  content: MyModalComponent,
  closeOnEscape: false,
} as ModalConfig);

Metadata

Metadata

Assignees

No one assigned

    Labels

    BacklogIts part of the team backlog

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions