Skip to content

Conversation

@nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Oct 31, 2025

💡 What is the current behavior?

JIRA: IX-2275

🆕 What is the new behavior?

  • Remove map navigation
  • Remove basic navigation

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: 71e1b6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Major
@siemens/ix-react Major
@siemens/ix Major
@siemens/ix-vue Major
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nuke-ellington nuke-ellington added this to the 4.0.0 milestone Oct 31, 2025
@nuke-ellington nuke-ellington marked this pull request as draft October 31, 2025 15:48
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nuke-ellington, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant cleanup by eliminating deprecated navigation components, specifically basic-navigation and map-navigation. The changes span across the entire project, removing all traces of these components from the core library, framework integrations (Angular, React, Vue), test applications, and documentation. This streamlines the codebase and removes outdated functionalities.

Highlights

  • Removal of Deprecated Components: The ix-basic-navigation and ix-map-navigation components, along with their associated overlay component (ix-map-navigation-overlay), have been completely removed from the library.
  • Codebase Cleanup: This removal includes deleting their core Stencil component implementations, SCSS styling, Angular, React, and Vue wrappers, as well as all related preview examples, test files, and Storybook documentation.
  • Application Layout Context Update: Adjustments were made to the ApplicationLayoutContext in ix-application-header and ix-menu to remove specific logic tied to the map-navigation host, streamlining the application's layout handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a comprehensive cleanup by removing the deprecated basic-navigation and map-navigation components. The removal is consistently applied across the core package, Angular, React, and Vue wrappers, test applications, and documentation. All related files, including component definitions, styles, tests, and examples, have been either removed or updated correctly. The changes are clean and significantly improve the maintainability of the codebase. The work is well-executed, and I have no further suggestions.

@danielleroux danielleroux changed the title feat(core/basic-navigation|map-navigation): remove deprecated navigat… feat(core/basic-navigation|map-navigation): remove deprecated navigation components Nov 4, 2025
@danielleroux danielleroux marked this pull request as ready for review November 4, 2025 10:45
@danielleroux danielleroux requested a review from lzeiml November 5, 2025 07:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

@danielleroux danielleroux merged commit e5642cb into main Nov 5, 2025
14 checks passed
@danielleroux danielleroux deleted the remove-deprecated-navs branch November 5, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants