fix(core/dropdown|dropdown-button): reflect disabled attribute in DOM when disabled property changes

[lakshmi-priya-b]

💡 What is the current behavior?

When the dropdown-item or dropdown-button is set to disabled dynamically,When looking into the DOM it only has a class of "disabled", not the attribute "disabled"

🆕 What is the new behavior?

Now whenever if we set the disabled property both statically or dynamically the property is being reflected in the dom.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

• 🦮 Accessibility (a11y) features were implemented
• 🗺️ Internationalization (i18n) - no hard coded strings
• 📲 Responsiveness - components handle viewport changes and content overflow gracefully
• 📕 Add or update a Storybook story
• 📄 Documentation was reviewed/updated siemens/ix-docs
• 🧪 Unit tests were added/updated and pass (pnpm test)
• 📸 Visual regression tests were added/updated and pass (Guide)
• 🧐 Static code analysis passes (pnpm lint)
• 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

[changeset-bot]

🦋 Changeset detected

Latest commit: 163f2eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@siemens/ix	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @lakshmi-priya-b, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the disabled property of dropdown components was not consistently reflected as an HTML attribute in the DOM, particularly when its value changed dynamically. By enabling attribute reflection for this property, the components now maintain accurate DOM representation of their disabled state, improving consistency and adherence to web standards. The changes are validated with new comprehensive regression tests.

Highlights

• DOM Reflection for Disabled State: The disabled property for ix-dropdown-button and ix-dropdown-item now correctly reflects its state as a disabled attribute in the DOM, both for static and dynamic changes.
• Property Configuration Update: The reflectToAttr setting for the disabled property in component-doc.json and the @Prop decorator in the component TypeScript files (dropdown-button.tsx, dropdown-item.tsx) has been updated to true.
• New Regression Tests: New regression tests have been added for both ix-dropdown-button and ix-dropdown-item to ensure the dynamic reflection of the disabled attribute functions as expected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses the issue of the disabled attribute not being reflected in the DOM for ix-dropdown-button and ix-dropdown-item when the property is changed dynamically. The fix, which involves adding { reflect: true } to the @Prop decorator for the disabled property in both components, is appropriate and effective. The inclusion of new regression tests is a great addition to verify the fix and prevent future regressions. I've made a couple of suggestions to improve the new tests by removing explicit timeouts, which can enhance their robustness.

[nuke-ellington]

We should add aria-disabled support

[lakshmi-priya-b]

We should add aria-disabled support

added aria-disabled support

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[lakshmi-priya-b]

Hi @nuke-ellington
Creating new PR for this with the same fix as there are so many merge conflicts with this branch.The review comments as well has been addressed in the new PR.(added support for aria-disabled).
Hence closing this PR.
New PR : [2261]