fix(core/time-picker): Fix scroll outside of component container on focus #2284
Conversation
🦋 Changeset detectedLatest commit: 5905719 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @lzeiml, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical scrolling bug within the time picker component. Previously, interacting with the time picker's number selection would inadvertently trigger a scroll on the entire page. The changes refactor the internal scrolling mechanism to ensure that only the time picker's container adjusts its scroll position, thereby isolating the component's behavior and significantly improving user interaction. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the scrolling issue in the time picker by replacing the problematic scrollIntoView with a custom scrolling implementation. The new logic correctly manipulates the scrollTop of the container, preventing unintended page scrolling. The change is well-contained and the new private method improves code organization. I have one minor suggestion to enhance readability by replacing a magic number with a named constant.
lzeiml
changed the title
…ens/ix into fix/3360_time-picker-scroll
|
💡 What is the current behavior?
Current autoscroll on focusing numbers inside the picker causes the whole page to scroll
GitHub issue: #2138
🆕 What is the new behavior?
Scrolling logic has been refactored to no longer affect scrolling outside the time picker container
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support