Skip to content

Commit 605c620

Browse files
committed
linux-iot2050: Workaround potential flash writing issue
Some issues with writing to the flash were found, particularly at high frequencies where up to 50% of attempts would fail in certain cases. Disabling the DAC, Direct ACcess, has proven effective in addressing this issue. This commit uses indirect mode to mitigate the problem. Workaround issue mentioned in PR #585 and it comes from upstream cce2200dacd6d7e0501c3811f24f5216710968fb. Upstream has rolled back it with 3cb2a2f7eebbb0752a834708e720a914e61841a1, ultimately the real issue needs to be fixed. Signed-off-by: Li Hua Qian <[email protected]>
1 parent 7ba8748 commit 605c620

File tree

1 file changed

+33
-0
lines changed

1 file changed

+33
-0
lines changed
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2+
From: Li Hua Qian <[email protected]>
3+
Date: Wed, 9 Apr 2025 13:02:41 +0800
4+
Subject: [PATCH] spi: cadence-qspi: Workaround potential flash writing issue
5+
6+
Some issues with writing to the flash were found, particularly at high
7+
frequencies where up to 50% of attempts would fail in certain cases.
8+
Disabling the DAC, Direct ACcess, has proven effective in addressing
9+
this issue. This commit uses indirect mode to mitigate the problem.
10+
11+
Workaround issue mentioned in PR #585 and it comes from upstream
12+
cce2200dacd6d7e0501c3811f24f5216710968fb. Upstream has rolled back it
13+
with 3cb2a2f7eebbb0752a834708e720a914e61841a1, ultimately the real issue
14+
needs to be fixed.
15+
16+
Signed-off-by: Li Hua Qian <[email protected]>
17+
---
18+
drivers/spi/spi-cadence-quadspi.c | 2 +-
19+
1 file changed, 1 insertion(+), 1 deletion(-)
20+
21+
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
22+
index 0f9af568f1fb..fd1cc00e28f1 100644
23+
--- a/drivers/spi/spi-cadence-quadspi.c
24+
+++ b/drivers/spi/spi-cadence-quadspi.c
25+
@@ -1815,7 +1815,7 @@ static const struct cqspi_driver_platdata k2g_qspi = {
26+
27+
static const struct cqspi_driver_platdata am654_ospi = {
28+
.hwcaps_mask = CQSPI_SUPPORTS_OCTAL,
29+
- .quirks = CQSPI_NEEDS_WR_DELAY,
30+
+ .quirks = CQSPI_DISABLE_DAC_MODE | CQSPI_NEEDS_WR_DELAY,
31+
};
32+
33+
static const struct cqspi_driver_platdata intel_lgm_qspi = {

0 commit comments

Comments
 (0)