Skip to content

fix: only use trackByProp on row level with strict type #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: only use trackByProp on row level with strict type #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/ngx-datatable/src/lib/components/body/body.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ export class DataTableBodyComponent<TRow extends Row = any> implements OnInit, O
readonly groupHeader = input<DatatableGroupHeaderDirective>();
readonly selectCheck = input<(value: TRow, index: number, array: TRow[]) => boolean>();
readonly displayCheck = input<(row: TRow, column: TableColumnInternal, value?: any) => boolean>();
readonly trackByProp = input<string>();
readonly trackByProp = input<keyof TRow>();
readonly rowClass = input<(row: TRow) => string | Record<string, boolean>>();
readonly groupedRows = input<Group<TRow>[]>();
// TODO: Find a better way to handle default expansion state with signal input
Expand Down Expand Up @@ -394,8 +394,8 @@ export class DataTableBodyComponent<TRow extends Row = any> implements OnInit, O
return index;
}
const trackByProp = this.trackByProp();
if (trackByProp && row) {
return (row as any)[trackByProp];
if (trackByProp && row && this.isRow(row)) {
return row[trackByProp];
} else if (row && this.isGroup(row)) {
return row.key ?? index;
} else {
Expand Down
2 changes: 1 addition & 1 deletion projects/ngx-datatable/src/lib/components/datatable.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ export class DatatableComponent<TRow extends Row = any>
* Property to which you can use for custom tracking of rows.
* Example: 'name'
*/
@Input() trackByProp?: string;
@Input() trackByProp?: keyof TRow;

/**
* Property to which you can use for determining select all
Expand Down
Loading