Skip to content

refactor: convert ghost-loading-indicator to signal input #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2025
Merged

refactor: convert ghost-loading-indicator to signal input #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/ngx-datatable/src/lib/components/datatable.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
[scrollbarH]="scrollbarH()"
[virtualization]="virtualization()"
[loadingIndicator]="loadingIndicator()"
[ghostLoadingIndicator]="ghostLoadingIndicator"
[ghostLoadingIndicator]="ghostLoadingIndicator()"
[externalPaging]="externalPaging()"
[rowHeight]="rowHeight()"
[rowCount]="rowCount"
Expand Down
26 changes: 14 additions & 12 deletions projects/ngx-datatable/src/lib/components/datatable.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,16 +309,7 @@ export class DatatableComponent<TRow extends Row = any>
* Show ghost loaders on each cell.
* Default value: `false`
*/
@Input({ transform: booleanAttribute }) set ghostLoadingIndicator(val: boolean) {
this._ghostLoadingIndicator = val;
if (val && this.scrollbarV() && !this.externalPaging()) {
// in case where we don't have predefined total page length
this.rows = [...this.rows, undefined]; // undefined row will render ghost cell row at the end of the page
}
}
get ghostLoadingIndicator(): boolean {
return this._ghostLoadingIndicator;
}
readonly ghostLoadingIndicator = input(false, { transform: booleanAttribute });

/**
* Type of row selection. Options are:
Expand Down Expand Up @@ -742,7 +733,6 @@ export class DatatableComponent<TRow extends Row = any>
_internalColumns!: TableColumnInternal<TRow>[];
_columns!: TableColumn[];
_subscriptions: Subscription[] = [];
_ghostLoadingIndicator = false;
_defaultColumnWidth = this.configuration?.defaultColumnWidth ?? 150;
/**
* To have this available for all components.
Expand All @@ -765,6 +755,18 @@ export class DatatableComponent<TRow extends Row = any>
// Ensure that we do not listen to other properties (yet).
untracked(() => this.translateColumns(columns));
});

// Effect to handle ghost loading indicator changes
effect(() => {
const ghostLoading = this.ghostLoadingIndicator();
// Use untracked to only subscribe to ghostLoadingIndicator changes
untracked(() => {
if (ghostLoading && this.scrollbarV() && !this.externalPaging()) {
// in case where we don't have predefined total page length
this.rows = [...this.rows, undefined]; // undefined row will render ghost cell row at the end of the page
}
});
});
}

/**
Expand All @@ -785,7 +787,7 @@ export class DatatableComponent<TRow extends Row = any>
const rowDiffers = this.rowDiffer.diff(this.rows);
if (rowDiffers || this.disableRowCheck()) {
// we don't sort again when ghost loader adds a dummy row
if (!this.ghostLoadingIndicator && !this.externalSorting() && this._internalColumns) {
if (!this.ghostLoadingIndicator() && !this.externalSorting() && this._internalColumns) {
this.sortInternalRows();
} else {
this._internalRows = [...this.rows];
Expand Down
Loading