Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed-operator lists aren't fully line-broken #1529

Open
ag-eitilt opened this issue Mar 4, 2024 · 0 comments
Open

Mixed-operator lists aren't fully line-broken #1529

ag-eitilt opened this issue Mar 4, 2024 · 0 comments
Labels
backlog Task that isn't actively being worked on bug Something isn't working wake-format

Comments

@ag-eitilt
Copy link
Collaborator

Lists which are constructed using only , or only ++ are both rendered correctly, but lists which contain some number of single items followed by two or more concatenated lists aren't properly broken:

def list =
    first,
    second,
    severalItems ++ severalMoreItems

Attaching @V-FEXrt's analysis from the internal issue spawning this:

Yeah I think this is a weird (but expected) interaction of not exploding binops when they are nested inside other binops.

In this case it seems like the ++s are inside of a binop(COMMA, lhs, ADD)

@ag-eitilt ag-eitilt added bug Something isn't working wake-format backlog Task that isn't actively being worked on labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Task that isn't actively being worked on bug Something isn't working wake-format
Projects
None yet
Development

No branches or pull requests

1 participant