Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed plain- and Result-pipelines are formatted poorly #1588

Open
ag-eitilt opened this issue Jun 20, 2024 · 0 comments
Open

Mixed plain- and Result-pipelines are formatted poorly #1588

ag-eitilt opened this issue Jun 20, 2024 · 0 comments
Labels
backlog Task that isn't actively being worked on bug Something isn't working wake-format

Comments

@ag-eitilt
Copy link
Collaborator

I gave confusing commentary on mixed pipelines previously; I don't think they're necessarily good style and I'd personally be hard-blocking anything which went back to plain pipelines after the result arrows, but for short cases where there's less chance of getting lost in the types I can see the utility over requiring an extra def just for form.

More broadly, I want to differentiate formatter bugs from style concerns -- like I said in #1470 (which is worse than this), even if people shouldn't do something, if it's legal the formatter should still be able to handle it. Obviously not with as great a priority if supporting some discouraged construct winds up requiring a lot of specialized formatter casing, but if it's minimal work it would still be ideal to give an at-least-passible output.

With that said, it shouldn't matter what pipeline operator is used, a mixed block of piping should still be uniformly linebroken.

-        someValue | functionThatReturnsResult
+        someValue
+        | functionThatReturnsResult
         |> anotherFunctionThatReturnsResult
@ag-eitilt ag-eitilt added bug Something isn't working wake-format backlog Task that isn't actively being worked on labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Task that isn't actively being worked on bug Something isn't working wake-format
Projects
None yet
Development

No branches or pull requests

1 participant