Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect definition of method Ingest.prototype.send() in the types file (TypeScript) #122

Open
axiac opened this issue Jun 10, 2024 · 0 comments · May be fixed by #123
Open

Incorrect definition of method Ingest.prototype.send() in the types file (TypeScript) #122

axiac opened this issue Jun 10, 2024 · 0 comments · May be fixed by #123

Comments

@axiac
Copy link

axiac commented Jun 10, 2024 •
edited
Loading

The method .send() of classes Ingest and IngestJson is described as returning void in the types file. But it returns a Promise.

This requires using await when it is called but using await triggers the line being flagged by the TypeScript compiler and by SonarQube.

The correct signature of send() is send(report: SignalReport): Promise<void>;.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct the return type of Ingest.send() (TypeScript) axiac/signalfx-nodejs
1 participant
@axiac