From 89d56f49cd55c04450a4f7ebbe329bbb969cc8aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mek=20Sk=C3=ABndo?= Date: Tue, 29 Oct 2024 18:56:04 +0100 Subject: [PATCH] #6 Check milestone --- check_done/checks.py | 5 +++++ check_done/done_project_items_info/info.py | 5 +++++ .../queries/project_v2_items.graphql | 6 ++++++ 3 files changed, 16 insertions(+) diff --git a/check_done/checks.py b/check_done/checks.py index c3bae7c..50f58aa 100644 --- a/check_done/checks.py +++ b/check_done/checks.py @@ -36,7 +36,12 @@ def _is_not_assigned(project_item: ProjectItemInfo) -> bool: return project_item.assignees.total_count < 1 +def _has_no_milestone(project_item: ProjectItemInfo) -> bool: + return project_item.milestone is None + + CONDITION_CHECK_AND_WARNING_REASON_LIST = [ (_is_not_closed, "not closed"), (_is_not_assigned, "missing assignee"), + (_has_no_milestone, "missing milestone"), ] diff --git a/check_done/done_project_items_info/info.py b/check_done/done_project_items_info/info.py index 6e05066..580a807 100644 --- a/check_done/done_project_items_info/info.py +++ b/check_done/done_project_items_info/info.py @@ -80,11 +80,16 @@ class AssigneesInfo(BaseModel): total_count: NonNegativeInt = Field(alias="totalCount") +class MilestoneInfo(BaseModel): + id: str + + class ProjectItemInfo(BaseModel): assignees: AssigneesInfo closed: bool number: NonNegativeInt repository: RepositoryInfo + milestone: MilestoneInfo | None title: str diff --git a/check_done/done_project_items_info/queries/project_v2_items.graphql b/check_done/done_project_items_info/queries/project_v2_items.graphql index f46bfaf..8307527 100644 --- a/check_done/done_project_items_info/queries/project_v2_items.graphql +++ b/check_done/done_project_items_info/queries/project_v2_items.graphql @@ -20,6 +20,9 @@ query projectV2Issues( totalCount } number + milestone { + id + } closed title repository { @@ -31,6 +34,9 @@ query projectV2Issues( totalCount } number + milestone { + id + } closed title repository {