Skip to content

Commit cdd6bbd

Browse files
committed
#31 Improve wording
1 parent 4616868 commit cdd6bbd

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

README.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,26 @@
77

88
# check_done
99

10-
A command-line tool that validates the completeness of GitHub project items (issue or pull request) in your specified project status that represents done project items.
10+
Check_done is a command line tool to check that GitHub issues and pull requests in a project board with a status of "Done" are really done.
1111

12-
Current checks are:
12+
It checks that:
1313

14-
- Project item is closed.
15-
- Project item has an assignee.
16-
- Project item has a set milestone.
17-
- Project item has all tasks completed (list with checkboxes in the description).
18-
- Pull request has a closing issue reference.
14+
- It is closed.
15+
- It has an assignee.
16+
- It is assigned to a milestone.
17+
- All tasks are completed (checkboxes in the description).
1918

20-
This ensures a consistent quality on done project items, and helps to notice if they were accidentally deemed to be done too early.
19+
Additionally, for pull requests, it checks if they reference an issue.
20+
21+
This ensures a consistent quality on done issues and pull requests, and helps to notice if they were accidentally deemed to be done too early.
2122

2223
## Installation
2324

2425
In order to gain access to your project board, issues, and pull requests, check_done needs to be authorized. The exact way to do that depends on whether your project belongs to a GitHub user or organization.
2526

2627
For user projects, [create a personal access token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens) with the permission: `read:project`.
2728

28-
For organization projects, follow the instructions to [Installing a GitHub App from a third party](https://docs.github.com/en/apps/using-github-apps/installing-a-github-app-from-a-third-party) using the [Check_done app](https://github.com/apps/check-done-app).
29-
30-
Remember the **app ID** and **private key** of the installed app.
29+
For organization projects, follow the instructions to [Installing a GitHub App from a third party](https://docs.github.com/en/apps/using-github-apps/installing-a-github-app-from-a-third-party) using the [Check_done app](https://github.com/apps/check-done-app). Remember the **app ID** and **private key** of the installed app in order to use for configuration.
3130

3231
## Configuration
3332

@@ -69,7 +68,7 @@ In order to avoid having to commit tokens and keys into your repository, you can
6968
personal_access_token: ${MY_PERSONAL_ACCESS_TOKEN_ENVVAR}
7069
```
7170

72-
### Changing the project status name to check
71+
### Changing the project status to check
7372

7473
By default, check_done checks all issues and pull requests in the last selectable project status. If you left the default names when creating the GitHub project board, this would be the `"✅ Done"` project status.
7574

check_done/command.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
logger = logging.getLogger(__name__)
1919

2020
_HELP_DESCRIPTION = (
21-
"A command-line tool that validates the completeness of GitHub project items "
22-
"(issue or pull request) in your specified project status that represents done project items."
21+
'Check that GitHub issues and pull requests in a project board with a status of "Done" are really done.'
2322
)
2423

2524

0 commit comments

Comments
 (0)