Naive implementation in plugin system

[sillydan1]

The function bool is_dynamic_library(const std::string& filename) implementation is quite naïve in the sense that it just checks if the filename contains dylib/so/dll.

This means that a file named foo.so.txt is considered a dynamic library and is the program attempts to load it as a plug-in.

A real solution would be to use terminfo to inspect what the given file is.

[kiner-shah]

Terminfo? Wouldn't that give information about terminal?

[sillydan1]

Terminfo? Wouldn't that give information about terminal?

Correct, I think I meant the 'file' command, or maybe https://en.cppreference.com/w/cpp/filesystem/file_type or similar

[kiner-shah]

Which file is this function in?

[sillydan1]

Which file is this function in?

Right, sorry. I was referring to the Linux file command 😄 I'm not sure if it is available on Windows though - and I'm also not sure which library it is part of 🤔

[kiner-shah]

I meant, which file is bool is_dynamic_library(const std::string& filename) in?

[sillydan1]

It's in the plugin_system.cpp 😄

[kiner-shah]

Maybe the check for is_dynamic_library isn't required. If dlopen fails, then it fails; instead of throwing a logic error, better to log a message "couldn't load file as shared/dynamic lib" and continue.

[sillydan1]

So, just remove

aaltitoad/src/plugin_system/plugin_system.cpp

Line 52 in 7ff31bb

if (is_dynamic_library(entry.path().filename())) {

? Yea, that probably works just fine 🤔

I might also downgrade the warning log to an info level, just so you dont get weird warnings about being unable to load non-plugin files.

[kiner-shah]

You may keep it at debug level actually, if a plugin is loaded, then a info level log would make sense.