Skip to content

Commit e86306c

Browse files
zanderwarrobbieaverill
authored andcommitted
FIX incorrect calculation of MAX_FILE_SIZE (#600)
* Fixes incorrect calculation of MAX_FILE_SIZE * Fixes expected bytes in EditableFileFiled test
1 parent 5777b33 commit e86306c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

code/model/editableformfields/EditableFileField.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public function getFormField()
9393
);
9494

9595
if ($this->MaxFileSizeMB > 0) {
96-
$field->getValidator()->setAllowedMaxFileSize($this->MaxFileSizeMB * 1024);
96+
$field->getValidator()->setAllowedMaxFileSize($this->MaxFileSizeMB * 1024 * 1024);
9797
} else {
9898
$field->getValidator()->setAllowedMaxFileSize(static::get_php_max_file_size());
9999
}

tests/EditableFileFieldTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public function testUpdatedMaxFileSize()
6161
$fileField->write();
6262

6363
$formField = $fileField->getFormField();
64-
$this->assertEquals($formField->getValidator()->getAllowedMaxFileSize(), 256);
64+
$this->assertEquals($formField->getValidator()->getAllowedMaxFileSize(), 262144);
6565
}
6666

6767
}

0 commit comments

Comments
 (0)