Fix resource file access when file does not exists

Author: t20100

src/silx/gui/icons.py

@@ -1,6 +1,6 @@
 # /*##########################################################################
 #
-# Copyright (c) 2016-2023 European Synchrotron Radiation Facility
+# Copyright (c) 2016-2025 European Synchrotron Radiation Facility
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -397,9 +397,12 @@ def getQFile(name):
 
     for format_ in _supported_formats:
         format_ = str(format_)
-        filename = silx.resources._resource_filename(
-            f"{name}.{format_}", default_directory="gui/icons"
-        )
+        try:
+            filename = silx.resources._resource_filename(
+                f"{name}.{format_}", default_directory="gui/icons"
+            )
+        except ValueError:
+            continue
         qfile = qt.QFile(filename)
         if qfile.exists():
             return qfile

src/silx/resources/__init__.py

@@ -1,6 +1,6 @@
 # /*##########################################################################
 #
-# Copyright (c) 2016-2023 European Synchrotron Radiation Facility
+# Copyright (c) 2016-2025 European Synchrotron Radiation Facility
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -65,7 +65,7 @@
 import logging
 import os
 import sys
-from typing import NamedTuple, Optional
+from typing import NamedTuple
 
 import importlib.resources as importlib_resources
 
@@ -237,9 +237,16 @@ def _get_resource_filename(package: str, resource: str) -> str:
     :return: Abolute resource path in the file system
     """
     # Caching prevents extracting the resource twice
-    file_context = importlib_resources.as_file(
-        importlib_resources.files(package) / resource
-    )
+    traversable = importlib_resources.files(package).joinpath(resource)
+    if not traversable.is_file() and not traversable.is_dir():
+        package_dir_context = importlib_resources.as_file(
+            importlib_resources.files(package)
+        )
+        path = _file_manager.enter_context(package_dir_context)
+        return str(path.absolute() / resource)
+
+    file_context = importlib_resources.as_file(traversable)
+
     path = _file_manager.enter_context(file_context)
     return str(path.absolute())