Build: Build and sign application budle for macOS #4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 2 comments.
Files not reviewed (6)
- package/windows/codesign.sh: Language not supported
- package/windows/create-dmg.sh: Language not supported
- package/windows/entitlements.plist: Language not supported
- package/windows/notarize.sh: Language not supported
- requirements-dev.txt: Language not supported
- tools/svg2icns.sh: Language not supported
Co-authored-by: Copilot <[email protected]>
t20100
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Thanks for the work, that sounds promissing!
We'll have to do 2 different bundles for arm and x86, does this works for both?
Are the files package/desktop/silx.icns and package/windows/DS_Store needed?
Let's rename package/windows. Suggestion: package/pyinstaller?
| @@ -0,0 +1,90 @@ | |||
| # Script to convert SVG files to macOS .icns format. | |||
| # Adapted from https://github.com/magnusviri/svg2icns. | |||
There was a problem hiding this comment.
Could you copy the copyright + license from the initial script here for reference?
| from silx import strictversion | ||
|
|
||
| base_name = os.path.join(SPECPATH, "artifacts", f"silx-{strictversion}-windows-application") | ||
| # Create a zip archive of the fat binary files. |
There was a problem hiding this comment.
Why not keeping the innosetup and make_zip helper functions instead of replacing them with a comment?
| if sys.platform == "darwin": | ||
| icon = "silx.icns" | ||
| elif sys.platform == "win32": | ||
| icon = "silx.ico" |
There was a problem hiding this comment.
Suggested change
| icon = "silx.ico" | |
| icon = "silx.ico" | |
| else: | |
| raise RuntimeError("Unsupported platform") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the PyInstaller build scripts to build an application bundle for macOS. It also submits the application for notarization with Apple.