Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval variable is not passed through anymore #144

Closed
KrisztianKaszas opened this issue Feb 1, 2021 · 9 comments · Fixed by #180
Closed

Interval variable is not passed through anymore #144

KrisztianKaszas opened this issue Feb 1, 2021 · 9 comments · Fixed by #180
Labels
backlog Would like it to be implemented

Comments

@KrisztianKaszas
Copy link

Dear SimPod Team,

I raised the following issue at Grafana gihub (grafana/grafana#30785). According to them, I shall report this issue here.

What you expected to happen: Interval variable and its selected value is submit to API via scopedVars

How to reproduce it (as minimally and precisely as possible):
Add simpod-json-datasource as datasource.
Add a new Dashboard
Add a new Variable with Type "Interval" to the dashboard, you may use the default list that is beeing provided.
Save
Refresh Dashboard
Capture API data via Fiddler.
Note that the variable is not present in scopedVariables anymore.

Anything else we need to know?:

Environment:

  • Grafana version: 7.3.7
  • Data source type & version: simpod-json-datasource 0.2.3
  • OS Grafana is installed on: Windows 10
  • User OS & Browser: Windows 10 and Chrome
  • Grafana plugins:
  • Others: In Grafana 6.4.4 with simpod-json-datasource 0.1.8 this feature worked.

Behavior 6.4.4 vs. 7.3.7 and Workaround:
106461630-52622300-6495-11eb-956c-df15efa92673

Best Regards
Krisztian

@simPod
Copy link
Owner

simPod commented Feb 2, 2021

Can you open devtools Console and see if there's a warning about Interval type not being supported?

@KrisztianKaszas
Copy link
Author

Indeed I receive "Variable of type "interval" is not supported" at DataSource.ts:198
Here is the according log:
localhost-1612254027439.log

@simPod
Copy link
Owner

simPod commented Feb 2, 2021

Thanks. This is to prevent new variable types that were not tested to behave unpredictably.

Eg. textbox variable was implemented here b85fbd2

Same as #129

@simPod simPod added the backlog Would like it to be implemented label Feb 2, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 19, 2021
@KrisztianKaszas
Copy link
Author

Please kindly keep this issue open.
Thx!
Krisztian

@simPod simPod removed the wontfix This will not be worked on label Mar 21, 2021
@simPod
Copy link
Owner

simPod commented Mar 21, 2021

There's a bug in stale bot that does not remove wontfix label after commenting. Did manually.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 2, 2021
@KrisztianKaszas
Copy link
Author

An anti-stale-bot message. Thx

@stale stale bot removed the wontfix This will not be worked on label Jun 2, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 8, 2021
@simPod simPod removed the wontfix This will not be worked on label Jul 8, 2021
@simPod simPod pinned this issue Jul 8, 2021
@simPod simPod unpinned this issue Jul 8, 2021
simPod added a commit that referenced this issue Jul 10, 2021
simPod added a commit that referenced this issue Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Would like it to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants