Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styles attribute should use typed attributes name instead of js.Dictionary #6

Open
simerplaha opened this issue May 2, 2017 · 0 comments
Open

styles attribute should use typed attributes name instead of js.Dictionary #6

simerplaha opened this issue May 2, 2017 · 0 comments
Labels
enhancement

Comments

@simerplaha
Copy link
Owner

simerplaha commented May 2, 2017 •
edited
Loading

Currently all styles get added to js.Dictionary. But the newer versions have typed properties

This HTML

<ul style="list-style: none; padding: 0;">

currently generates this

<.ul(^.style := js.Dictionary("list-style" -> "none", "padding" -> "0"))

But now we should generate this for Scalajs-react's VDOM

<.ul(^.listStyle := "none", ^.padding := "0")

and this for Scalatags

ul(listStyle := "none", padding := "0")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simerplaha