From 472615a00889c2fa79a09279c6fb15974401ac68 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Wed, 14 Feb 2024 22:44:49 +0100
Subject: [PATCH] Bump the all-actions group with 3 updates (#33)

* Bump the all-actions group with 3 updates

Bumps the all-actions group with 3 updates: [actions/cache](https://github.com/actions/cache), [actions/download-artifact](https://github.com/actions/download-artifact) and [codecov/codecov-action](https://github.com/codecov/codecov-action).


Updates `actions/cache` from 3 to 4
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3...v4)

Updates `actions/download-artifact` from 3 to 4
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4)

Updates `codecov/codecov-action` from 3 to 4
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-actions
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-actions
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-actions
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix psalm-issue

* Remove unused use-statement

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tim van Dijen <tvdijen@gmail.com>
---
 .github/workflows/php.yml                | 12 ++++++------
 tests/src/Controller/MetaRefreshTest.php |  7 +------
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
index ed454b4..77c84bc 100644
--- a/.github/workflows/php.yml
+++ b/.github/workflows/php.yml
@@ -62,7 +62,7 @@ jobs:
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"
 
       - name: Cache composer dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: $COMPOSER_CACHE
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -128,7 +128,7 @@ jobs:
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"
 
       - name: Cache composer dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: $COMPOSER_CACHE
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -184,7 +184,7 @@ jobs:
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$GITHUB_ENV"
 
       - name: Cache composer dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: $COMPOSER_CACHE
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -246,7 +246,7 @@ jobs:
         run: echo COMPOSER_CACHE="$(composer config cache-files-dir)" >> "$env:GITHUB_ENV"
 
       - name: Cache composer dependencies
-        uses: actions/cache@v3
+        uses: actions/cache@v4
         with:
           path: $COMPOSER_CACHE
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -265,13 +265,13 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: coverage-data
           path: ${{ github.workspace }}/build
 
       - name: Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           fail_ci_if_error: true
diff --git a/tests/src/Controller/MetaRefreshTest.php b/tests/src/Controller/MetaRefreshTest.php
index 29707a7..f1f1e32 100644
--- a/tests/src/Controller/MetaRefreshTest.php
+++ b/tests/src/Controller/MetaRefreshTest.php
@@ -8,7 +8,6 @@
 use SimpleSAML\Configuration;
 use SimpleSAML\Module\metarefresh\Controller;
 use SimpleSAML\Utils;
-use Symfony\Component\HttpFoundation\Request;
 
 /**
  * Set of tests for the controllers in the "metarefresh" module.
@@ -94,17 +93,13 @@ public function testMetaRefresh()
         $_SERVER['SERVER_PROTOCOL'] = 'HTTP/1.1';
 
         Configuration::setPreLoadedConfig($this->authsources, 'authsources.php');
-        $request = Request::create(
-            '/',
-            'GET'
-        );
 
         $c = new Controller\MetaRefresh($this->config);
         $c->setAuthUtils($this->authUtils);
         $c->setModuleConfig($this->module_config);
 
         /** @var \SimpleSAML\XHTML\Template $response */
-        $response = $c->main($request);
+        $response = $c->main();
 
         $this->assertTrue($response->isSuccessful());