Improve HTTPError message to include method and URL

Fixes #1126

Author: sindresorhus

source/core/errors.ts

@@ -96,7 +96,7 @@ export class HTTPError<T = any> extends RequestError<T> {
 	declare readonly timings: Timings;
 
 	constructor(response: PlainResponse) {
-		super(`Response code ${response.statusCode} (${response.statusMessage!})`, {}, response.request);
+		super(`Request failed with status code ${response.statusCode} (${response.statusMessage!}): ${response.request.options.method} ${response.request.options.url!.toString()}`, {}, response.request);
 		this.name = 'HTTPError';
 		this.code = 'ERR_NON_2XX_3XX_RESPONSE';
 	}

test/error.ts

@@ -28,7 +28,7 @@ test('properties', withServer, async (t, server, got) => {
 	t.true(Object.prototype.propertyIsEnumerable.call(error, 'options'));
 	t.false(Object.prototype.propertyIsEnumerable.call(error, 'response'));
 	t.is(error.code, 'ERR_NON_2XX_3XX_RESPONSE');
-	t.is(error.message, 'Response code 404 (Not Found)');
+	t.regex(error.message, /^Request failed with status code 404 \(Not Found\): GET http:\/\/localhost:\d+\/$/);
 	t.deepEqual(error.options.url, url);
 	t.is(error.response.headers.connection, 'keep-alive');
 	// Assert is used for type checking
@@ -78,7 +78,7 @@ test('default status message', withServer, async (t, server, got) => {
 	const error = await t.throwsAsync<HTTPError>(got(''),
 		{
 			instanceOf: HTTPError,
-			message: 'Response code 400 (Bad Request)',
+			message: /^Request failed with status code 400 \(Bad Request\): GET http:\/\/localhost:\d+\/$/,
 		});
 	t.is(error?.response.statusCode, 400);
 	t.is(error?.response.statusMessage, 'Bad Request');
@@ -94,7 +94,7 @@ test('custom status message', withServer, async (t, server, got) => {
 	const error = await t.throwsAsync<HTTPError>(got(''),
 		{
 			instanceOf: HTTPError,
-			message: 'Response code 400 (Something Exploded)',
+			message: /^Request failed with status code 400 \(Something Exploded\): GET http:\/\/localhost:\d+\/$/,
 		});
 	t.is(error?.response.statusCode, 400);
 	t.is(error?.response.statusMessage, 'Something Exploded');
@@ -109,7 +109,7 @@ test('custom body', withServer, async (t, server, got) => {
 	const error = await t.throwsAsync<HTTPError>(got(''),
 		{
 			instanceOf: HTTPError,
-			message: 'Response code 404 (Not Found)',
+			message: /^Request failed with status code 404 \(Not Found\): GET http:\/\/localhost:\d+\/$/,
 		});
 	t.is(error?.response.statusCode, 404);
 	// Typecheck for default `any` type
@@ -128,7 +128,7 @@ test('custom json body', withServer, async (t, server, got) => {
 	const error = await t.throwsAsync<HTTPError<{message: string}>>(got('', {responseType: 'json'}),
 		{
 			instanceOf: HTTPError,
-			message: 'Response code 404 (Not Found)',
+			message: /^Request failed with status code 404 \(Not Found\): GET http:\/\/localhost:\d+\/$/,
 		});
 	t.is(error?.response.statusCode, 404);
 	// Assert is used for body typecheck
@@ -150,7 +150,7 @@ test('contains Got options', withServer, async (t, server, got) => {
 	const error = await t.throwsAsync<HTTPError>(got(options),
 		{
 			instanceOf: HTTPError,
-			message: 'Response code 404 (Not Found)',
+			message: /^Request failed with status code 404 \(Not Found\): GET http:\/\/localhost:\d+\/$/,
 		});
 	t.is(error?.response.statusCode, 404);
 	t.is(error?.options.context.foo, options.context.foo);
@@ -165,7 +165,7 @@ test('empty status message is overriden by the default one', withServer, async (
 	const error = await t.throwsAsync<HTTPError>(got(''),
 		{
 			instanceOf: HTTPError,
-			message: 'Response code 400 (Bad Request)',
+			message: /^Request failed with status code 400 \(Bad Request\): GET http:\/\/localhost:\d+\/$/,
 		});
 	t.is(error?.response.statusCode, 400);
 	t.is(error?.response.statusMessage, http.STATUS_CODES[400]);

test/hooks.ts

@@ -853,7 +853,7 @@ test('no infinity loop when retrying on afterResponse', withServer, async (t, se
 				}),
 			],
 		},
-	}), {instanceOf: HTTPError, message: 'Response code 401 (Unauthorized)'});
+	}), {instanceOf: HTTPError, message: /^Request failed with status code 401 \(Unauthorized\): GET http:\/\/localhost:\d+\/$/});
 });
 
 test('throws on afterResponse retry failure', withServer, async (t, server, got) => {
@@ -888,7 +888,7 @@ test('throws on afterResponse retry failure', withServer, async (t, server, got)
 				},
 			],
 		},
-	}), {instanceOf: HTTPError, message: 'Response code 500 (Internal Server Error)'});
+	}), {instanceOf: HTTPError, message: /^Request failed with status code 500 \(Internal Server Error\): GET http:\/\/localhost:\d+\/$/});
 });
 
 test('does not throw on afterResponse retry HTTP failure if throwHttpErrors is false', withServer, async (t, server, got) => {
@@ -1174,7 +1174,7 @@ test('beforeError is called with an error - stream', withServer, async (t, _serv
 				return error2;
 			}],
 		},
-	})), {message: 'Response code 404 (Not Found)'});
+	})), {message: /^Request failed with status code 404 \(Not Found\): GET http:\/\/localhost:\d+\/$/});
 });
 
 test('beforeError allows modifications', async t => {
@@ -1314,7 +1314,7 @@ test('hooks are not duplicated', withServer, async (t, _server, got) => {
 		retry: {
 			limit: 0,
 		},
-	}), {message: 'Response code 404 (Not Found)'});
+	}), {message: /^Request failed with status code 404 \(Not Found\): GET http:\/\/localhost:\d+\/$/});
 
 	t.is(calls, 1);
 });

test/response-parse.ts

@@ -120,7 +120,7 @@ test('ignores errors on invalid non-200 responses', withServer, async (t, server
 
 	const error = await t.throwsAsync<HTTPError>(got({responseType: 'json', retry: {limit: 0}}), {
 		instanceOf: HTTPError,
-		message: 'Response code 500 (Internal Server Error)',
+		message: /^Request failed with status code 500 \(Internal Server Error\): GET http:\/\/localhost:\d+\/$/,
 	});
 
 	t.is(error?.response.body, 'Internal error');

test/retry.ts

@@ -404,7 +404,7 @@ test('does not break on redirect', withServer, async (t, server, got) => {
 		response.end();
 	});
 
-	await t.throwsAsync(got('redirect'), {message: 'Response code 500 (Internal Server Error)'});
+	await t.throwsAsync(got('redirect'), {message: /^Request failed with status code 500 \(Internal Server Error\): GET http:\/\/localhost:\d+\/$/});
 	t.is(tries, 1);
 });
 

test/stream.ts

@@ -139,7 +139,7 @@ test('has error event', withServer, async (t, server, got) => {
 	const stream = got.stream('');
 	await t.throwsAsync(pEvent(stream, 'response'), {
 		instanceOf: HTTPError,
-		message: 'Response code 404 (Not Found)',
+		message: /^Request failed with status code 404 \(Not Found\): GET http:\/\/localhost:\d+\/$/,
 	});
 });