FIx preserving prefixUrl in hooks

Fixes #2124

Author: sindresorhus

source/core/index.ts

@@ -906,7 +906,6 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 					}
 
 					this.redirectUrls.push(redirectUrl);
-					updatedOptions.prefixUrl = '';
 					updatedOptions.url = redirectUrl;
 
 					for (const hook of updatedOptions.hooks.beforeRedirect) {
@@ -1290,9 +1289,6 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 			}
 		}
 
-		// Reset `prefixUrl`
-		options.prefixUrl = '';
-
 		let request: ReturnType<Options['getRequestFunction']> | undefined;
 
 		for (const hook of options.hooks.beforeRequest) {

source/core/options.ts

@@ -1075,10 +1075,6 @@ const cloneInternals = (internals: typeof defaultInternals) => {
 		pagination: {...internals.pagination},
 	};
 
-	if (result.url !== undefined) {
-		result.prefixUrl = '';
-	}
-
 	return result;
 };
 
@@ -1648,7 +1644,12 @@ export default class Options {
 			throw new Error('`url` must not start with a slash');
 		}
 
-		const urlString = `${this.prefixUrl as string}${value.toString()}`;
+		// Detect if URL is already absolute (has a protocol/scheme)
+		const valueString = value.toString();
+		const isAbsolute = is.urlInstance(value) || /^[a-z][a-z\d+.-]*:/i.test(valueString);
+
+		// Only concatenate prefixUrl if the URL is relative
+		const urlString = isAbsolute ? valueString : `${this.prefixUrl as string}${valueString}`;
 		const url = new URL(urlString);
 		this._internals.url = url;
 

test/hooks.ts

@@ -592,6 +592,78 @@ test('beforeRetry allows stream body if different from original', withServer, as
 	t.is(body, 'test');
 });
 
+test('prefixUrl is preserved in beforeRequest hook', withServer, async (t, server, got) => {
+	server.get('/endpoint', (_request, response) => {
+		response.end('success');
+	});
+
+	let capturedPrefixUrl: string | URL | undefined;
+
+	await got('endpoint', {
+		prefixUrl: server.url,
+		hooks: {
+			beforeRequest: [
+				options => {
+					capturedPrefixUrl = options.prefixUrl;
+				},
+			],
+		},
+	});
+
+	const normalizedServerUrl = new URL(server.url).toString();
+	t.is(capturedPrefixUrl, normalizedServerUrl);
+});
+
+test('prefixUrl is preserved in beforeRetry hook', withServer, async (t, server, got) => {
+	server.get('/retry', (_request, response) => {
+		response.statusCode = 500;
+		response.end();
+	});
+
+	let capturedPrefixUrl: string | URL | undefined;
+
+	await t.throwsAsync(got('retry', {
+		prefixUrl: server.url,
+		retry: {
+			limit: 1,
+		},
+		hooks: {
+			beforeRetry: [
+				({options}) => {
+					capturedPrefixUrl = options.prefixUrl;
+				},
+			],
+		},
+	}));
+
+	const normalizedServerUrl = new URL(server.url).toString();
+	t.is(capturedPrefixUrl, normalizedServerUrl);
+});
+
+test('setting absolute URL in hook does not concatenate with prefixUrl', withServer, async (t, server, got) => {
+	server.get('/original', (_request, response) => {
+		response.end('original');
+	});
+
+	server.get('/changed', (_request, response) => {
+		response.end('changed');
+	});
+
+	const {body} = await got('original', {
+		prefixUrl: server.url,
+		hooks: {
+			beforeRequest: [
+				options => {
+					// Set absolute URL - should not concatenate with prefixUrl
+					options.url = new URL(`${server.url}/changed`);
+				},
+			],
+		},
+	});
+
+	t.is(body, 'changed');
+});
+
 test('afterResponse is called with response', withServer, async (t, server, got) => {
 	server.get('/', echoHeaders);