Request not sent when uploading files to server

[xinkule]

In got, I write the following but nothing happens. Not a response or an error, none of the hooks are executed.

const stream = fs.createReadStream(path);
const signature = calculateSignature(headers);
return got
  .post(`${rootPath}/file/upload`, {
    body: stream,
    headers: {
      ...headers,
      'Content-Type': 'application/octet-stream',
      'Content-Length': String(size),
      'signature': signature,
    },
    hooks: {
      beforeRequest: [
        () => {
          console.log('request');
        },
      ],
      beforeError: [
        (error) => {
          console.log('eror');
          return error;
        },
      ],
    },
  })
  .json<{ code: string; message: string; data: string }>();

I've searched issues and docs, cannot find a comprehensive guideline of how to upload files. Here is how I achieve the same thing in axios :

const stream = fs.createReadStream(path);
const signature = calculateSignature(headers);
return axios.post(`${rootPath}/file/upload`, stream, {
  headers: {
    ...headers,
    'Content-Type': 'application/octet-stream',
    'Content-Length': fileSize,
    signature: signature,
  },
});

Could really need some help, thanks.

[xinkule]

Ok, I did some digging, and finally find out the problem.

Development environment:
Node.js: 14.15.0
got: 11.8.2
fs-extra: 10.0.0

I create the readable stream using fs-extra, and the wired thing is , it never triggers the stream ready event in the got source code below :

const waitForOpenFile = async (file: ReadStream): Promise<void> =>
  new Promise((resolve, reject) => {
    const onError = (error: Error): void => {
      reject(error);
    };

    // Node.js 12 has incomplete types
    if (!(file as any).pending) {
      resolve();
    }

    file.once('error', onError);
    // event never triggered
    file.once('ready', () => {
      file.off('error', onError);
      resolve();
    });
  });

// the promise here never resolves
if (this.options.body instanceof ReadStream) {
  await waitForOpenFile(this.options.body);
}

Eventually, got cannot even make the request. I'am not sure this is the bug of fs-extra or got, hope you guys could figure it out. FYI @szmarczak @sindresorhus