Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp filter filters everything #87

Open
sherlock1982 opened this issue Mar 5, 2018 · 4 comments
Open

Gulp filter filters everything #87

sherlock1982 opened this issue Mar 5, 2018 · 4 comments
Labels
bug 💵 Funded on Issuehunt This issue has been funded on Issuehunt

Comments

@sherlock1982
Copy link

sherlock1982 commented Mar 5, 2018

Issuehunt badges

Version 5.0.0 works ok, version 5.0.1 broken.
Looks like a change was made between 5.0.0 and 5.0.1 and now filter just skips everything.
Here's a simplified code snippet which:

function(svn_revision){
    var xmlFilter = filter("../**/*.xml", {restore: true});

    return gulp.src([
            "../Setup/Installed/Data/Http/Templates/**/*",
        ], { base : '../' })
        .pipe(xmlFilter)
        .pipe(replace('@PRODUCT_SVN_BUILD@', svn_revision))
        .pipe(xmlFilter.restore)
        .pipe(gulp.dest("../BinRepo/Templates"));
},

Expected behavior: All xml files should have @PRODUCT_SVN_BUILD@ replaced.
Actual behavior: Looks like they're just written to dest folder.

UPD: Looks like 5.0.0 doesn't work on Linux


IssueHunt Summary

Sponsors (Total: $40.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

@gchamon
Copy link

gchamon commented Jun 26, 2018

+1 same here, downgrading

@gchamon
Copy link

gchamon commented Jun 26, 2018

4 is also broken here, sticking with ~3.0

@sergeymorkovkin
Copy link

Version 5.1.0 - broken. Filters out everything.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 9, 2019
@IssueHuntBot
Copy link

@issuehunt has funded $40.00 to this issue.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💵 Funded on Issuehunt This issue has been funded on Issuehunt
Projects
None yet
Development

No branches or pull requests

5 participants